Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264359AbTIJDWh (ORCPT ); Tue, 9 Sep 2003 23:22:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264409AbTIJDWh (ORCPT ); Tue, 9 Sep 2003 23:22:37 -0400 Received: from smtp4.us.dell.com ([143.166.148.135]:48038 "EHLO smtp4.us.dell.com") by vger.kernel.org with ESMTP id S264359AbTIJDWe (ORCPT ); Tue, 9 Sep 2003 23:22:34 -0400 Date: Tue, 9 Sep 2003 17:22:00 -0500 (CDT) From: Matt Domsch X-X-Sender: mdomsch@localhost.localdomain To: Greg KH cc: Dave Jones , Anatoly Pugachev , Subject: Re: agpgart support for intel SHG2 motherboard, serverworks chipset In-Reply-To: <20030905000452.GF12613@kroah.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 30 > > Anatoly, I've cc'd Greg on this one, as you managed to break the > > sysfs new_id stuff that he wrote, so I think he may be interested > > in fixing that up 8-) agp_serverworks_probe() is marked __init. Thus the static lookup called by the new_id code fails as this function is no longer in the kernel. The fix is to remove __init from the probe routines. I'm looking to see how often this occurs elsewhere. sworks-agp.c also can't make effective use of the new_id code because it registers a single all-covering serverworks pci_device_id, then its probe routine checks for three specific device IDs and bails if it's not them. The new_id code can't help here. The "right" way would be to register three separate entries in the pci_table and not test for them in the probe routine. Thanks, Matt -- Matt Domsch Sr. Software Engineer Dell Linux Solutions www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/