Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 22 Jun 2018 11:44:16 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Quentin Monnet <quentin.monnet@netronome.com>
Cc:     Okash Khawaja <osk@fb.com>, Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Yonghong Song <yhs@fb.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/3] bpf: btf: add btf json print functionality
Message-ID: <20180622114416.23ff14b9@cakuba.netronome.com>
In-Reply-To: <a598aea7-e967-1779-5092-937565a69c0b@netronome.com>
References: <20180620203051.223156973@fb.com>
        <20180620203703.101156292@fb.com>
        <3db6047a-101a-2ed1-9ca3-9e90b45ea00f@netronome.com>
        <20180622102428.GA3050@w1t1fb>
        <a598aea7-e967-1779-5092-937565a69c0b@netronome.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 22 Jun 2018 11:39:13 +0100, Quentin Monnet wrote:
> 2018-06-22 11:24 UTC+0100 ~ Okash Khawaja <osk@fb.com>
> > On Thu, Jun 21, 2018 at 11:42:59AM +0100, Quentin Monnet wrote:  
> >> Hi Okash,  
> > hi and sorry about delay in responding. the email got routed to
> > incorrect folder.  
> >>
> >> 2018-06-20 13:30 UTC-0700 ~ Okash Khawaja <osk@fb.com>  
>  [...]  
> >>
> >> Hexadecimal values, without quotes, are not valid JSON. Please stick to
> >> decimal values.  
> > ah sorry, i used a buggy json validator. this should be a quick fix.
> > which would be better:  pointers be output hex strings or integers?  
> 
> I would go for integers. Although this is harder to read for humans, it
> is easier to process for machines, which remain the primary targets for
> JSON output.

+1