Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp1455905imm; Fri, 22 Jun 2018 17:49:12 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKSrfXE5SMVdtxavvTxKyCz5y/KMizmIBjRqhnBdcPrynJltCcaI1NriMy7HU4FHmaIJmje X-Received: by 2002:a62:1013:: with SMTP id y19-v6mr3809111pfi.166.1529714951962; Fri, 22 Jun 2018 17:49:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529714951; cv=none; d=google.com; s=arc-20160816; b=EhsFulusCnFtUTfpuSKOl0uvxlZF0ytQTKVHpZDKOaYSdSypOyTGkZvrrC23JWqJNJ uaZNoU+HRUKrXwKXluE5/t12x8ZaEbJ10ac2KEVL+48Mt468cY1jvY1sNe4gEBvmj5XY TZswXHWpCNwtueMyh55cxUr7ZnKSgBHQAQY15UysMDIMeeH2PhyhdYIDXQ0pWkngpHK6 h4wmqVTycBpAvoryfQPPwGRlrgVD5G81Pz3y4f1Meh+sR6ump2gFFLHA5HItSoEqUpqk 8k9bRdNFdk9g1hLBl0sYa87uJ1hdEqym3Nc1LMiqhnxuu32XMl5fMGP4MJaBki3e45om L2pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=8J8y19jDKGDbbyIXXNqXzwwIGH5vC6JPcO8YOkghcEQ=; b=Fxsw44dlV+h+AdBctJ0aMDJ7YJkES5uaNqBJPbEkTCKTmw3FlSz+KlZC3qM248djep sQNgswzJFjKH3EudZu3zLryWQc6VM0prLiG1wtG8YDGVx0jYc3SLtne4ctYlXvkyJA2H SfOba+jrtxI+OwfFoDm89StQIF/nE1WfElDTtoOd/6IzmiMZtiDQTZDFS8nY9wruTgcG HgR6Ayf0jwYze9w9/jxq0xCbEnACZo7RYpCgnopns/FoS1JhwjB8XWo7GjzDrLYWgKBU cpHs7ksSr9Kj4dtKFSpRuTq7DBoRrXbP1wWQsimRzg6XsM4o7YwZr5VT9aHYDkFLsYws p/ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pHfIObsX; dkim=pass header.i=@codeaurora.org header.s=default header.b="Rc7yo79/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f14-v6si8053575plr.365.2018.06.22.17.48.57; Fri, 22 Jun 2018 17:49:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=pHfIObsX; dkim=pass header.i=@codeaurora.org header.s=default header.b="Rc7yo79/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934525AbeFWAqf (ORCPT + 99 others); Fri, 22 Jun 2018 20:46:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59336 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934302AbeFWAqd (ORCPT ); Fri, 22 Jun 2018 20:46:33 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 510FD60275; Sat, 23 Jun 2018 00:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529714793; bh=v7buNuVFzpnVJsADR4vrFzqFI74kUBo3/b4G/Peoo4o=; h=From:To:Cc:Subject:Date:From; b=pHfIObsXRKmjYhZho5n8YCBJ93TX8gxBNYHik7qgP42Jzxohhn2wnaEENyAajNv3c CyXx1QkPkLw6b/NrQ2WaRYVujLqt1bHzrBk4afqqfVz9/m/pKSQsQXHTv3IMwxFkeF RHS89ctoDahGWahwgczv8sKFAs2c/syuUdBArzuE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from codeaurora.org (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: collinsd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 60BB060275; Sat, 23 Jun 2018 00:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1529714791; bh=v7buNuVFzpnVJsADR4vrFzqFI74kUBo3/b4G/Peoo4o=; h=From:To:Cc:Subject:Date:From; b=Rc7yo79/6IUPzWehKKb81jFGHXU5lE5PaJL9MomPyLosVHWq/pFqdZ46/yZbcHq9O 2su3Tx5OEIS4tA4CsTTinxf8EigxEz4BKrAytvXKX9L7JeTen2U/pKb5QAtDsDsCSR x58WRmixmQKnjFcd9+QgqZ6B4Au0EyubrML44qBg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 60BB060275 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=collinsd@codeaurora.org From: David Collins To: broonie@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: David Collins , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org, sboyd@kernel.org, dianders@chromium.org, mka@chromium.org Subject: [PATCH v8 0/2] regulator: add QCOM RPMh regulator driver Date: Fri, 22 Jun 2018 17:46:12 -0700 Message-Id: X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series adds a driver and device tree binding documentation for PMIC regulator control via Resource Power Manager-hardened (RPMh) on some Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC. The final hardware state of a regulator is determined within RPMh by performing max aggregation of the requests made by all of the processors. The RPMh regulator driver depends upon the RPMh driver [1] and command DB driver [2] which are both still undergoing review. It also depends upon three recent regulator patches: [3], [4], and [5] as well as an RPMh helper patch [6]. Changes since v7 [7]: - Removed the cmd_db_ready() call from the driver probe function as it is now handled by the RPMh driver itself [6] - Added Reviewed-by tag for driver patch 2/2 Changes since v6 [8]: - Removed 'count' parameter from rpmh_regulator_send_request() since it is always 1 - Fixed _rpmh_regulator_vrm_set_voltage_sel() return value - Added a helper function to capture common code between rpmh_regulator_enable() and rpmh_regulator_disable() - Added an iterator for pmic_rpmh_data in rpmh_regulator_init_vreg() - Added Reviewed-by tag for both patches Changes since v5 [9]: - Removed unused constants - Added Reviewed-by tag for DT patch 1/2 Changes since v4 [10]: - Removed support for DT properties qcom,regulator-drms-modes and qcom,drms-mode-max-microamps - Specified fixed DRMS high power mode minimum limits for LDO type regulators - Removed DRMS support for SMPS and BOB type regulators - Simplified voltage caching logic Changes since v3 [11]: - Removed support for DT properties qcom,regulator-initial-microvolt and qcom,headroom-microvolt - Renamed DT property qcom,allowed-drms-modes to be qcom,regulator-drms-modes - Updated DT binding documentation to mention which common regulator bindings can be used for qcom-rpmh-regulator devices - Added voltage caching so that voltage requests are only sent to RPMh after the regulator has been enabled at least once - Changed 'voltage_selector' default value to be -ENOTRECOVERABLE to interact with [5] - Initialized 'enabled' to -EINVAL so that unused regulators are disabled by regulator_late_cleanup() - Removed rpmh_regulator_load_default_parameters() as it is no longer needed - Updated the mode usage description in qcom,rpmh-regulator.h Changes since v2 [12]: - Replaced '_' with '-' in device tree supply property names - Renamed qcom_rpmh-regulator.c to be qcom-rpmh-regulator.c - Updated various DT property names to use "microvolt" and "microamp" - Moved allowed modes constraint specification out of the driver [4] - Replaced rpmh_client with device pointer to match new RPMh API [1] - Corrected drms mode threshold checking - Initialized voltage_selector to -EINVAL when not specified in DT - Added constants for PMIC regulator hardware modes - Corrected type sign of mode mapping tables - Made variable names for mode arrays plural - Simplified Kconfig depends on - Removed unnecessary constants and struct fields - Added some descriptive comments Changes since v1 [13]: - Addressed review feedback from Doug, Mark, and Stephen - Replaced set_voltage()/get_voltage() callbacks with set_voltage_sel()/ get_voltage_sel() - Added set_bypass()/get_bypass() callbacks for BOB pass-through mode control - Removed top-level PMIC data structures - Removed initialization variables from structs and passed them as function parameters - Removed various comments and error messages - Simplified mode handling - Refactored per-PMIC rpmh-regulator data specification - Simplified probe function - Moved header into DT patch - Removed redundant property listings from DT binding documentation [1]: https://lkml.org/lkml/2018/6/20/519 [2]: https://lkml.org/lkml/2018/4/10/714 [3]: https://lkml.org/lkml/2018/4/18/556 [4]: https://lkml.org/lkml/2018/5/11/696 [5]: https://lkml.org/lkml/2018/5/15/1005 [6]: https://lkml.org/lkml/2018/6/18/1188 [7]: https://lkml.org/lkml/2018/6/8/573 [8]: https://lkml.org/lkml/2018/6/4/879 [9]: https://lkml.org/lkml/2018/6/1/895 [10]: https://lkml.org/lkml/2018/5/22/1168 [11]: https://lkml.org/lkml/2018/5/11/701 [12]: https://lkml.org/lkml/2018/4/13/687 [13]: https://lkml.org/lkml/2018/3/16/1431 David Collins (2): regulator: dt-bindings: add QCOM RPMh regulator bindings regulator: add QCOM RPMh regulator driver .../bindings/regulator/qcom,rpmh-regulator.txt | 160 +++++ drivers/regulator/Kconfig | 9 + drivers/regulator/Makefile | 1 + drivers/regulator/qcom-rpmh-regulator.c | 746 +++++++++++++++++++++ .../dt-bindings/regulator/qcom,rpmh-regulator.h | 36 + 5 files changed, 952 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt create mode 100644 drivers/regulator/qcom-rpmh-regulator.c create mode 100644 include/dt-bindings/regulator/qcom,rpmh-regulator.h -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project