Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <alpine.DEB.2.21.1806231402500.8650@nanos.tec.linutronix.de>
References: <alpine.DEB.2.21.1806231402500.8650@nanos.tec.linutronix.de> <cover.1529706536.git.reinette.chatre@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     dhowells@redhat.com, Reinette Chatre <reinette.chatre@intel.com>,
        fenghua.yu@intel.com, Tony Luck <tony.luck@intel.com>,
        vikas.shivappa@linux.intel.com, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, mingo@redhat.com,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15107.1529795694.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: 8BIT
Date:   Sun, 24 Jun 2018 00:14:54 +0100
Message-ID: <15108.1529795694@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thomas Gleixner <tglx@linutronix.de> wrote:

>  - Stick the struct into the local header file and not at some random place in
>    the source.

Why?  It's only used in that one file.  There doesn't seem to be any
particular need to share it around.

>  - Get rid of the fugly camel case

It's not camel case.  It's the name of the option it's encoding.  But if it
makes you happy...

>  - Move the enablement into a separate function

Okay.

David