Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 24 Jun 2018 02:28:49 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     David Howells <dhowells@redhat.com>
cc:     Reinette Chatre <reinette.chatre@intel.com>, fenghua.yu@intel.com,
        Tony Luck <tony.luck@intel.com>,
        vikas.shivappa@linux.intel.com, gavin.hindman@intel.com,
        jithu.joseph@intel.com, dave.hansen@intel.com, mingo@redhat.com,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache
 Pseudo-Locking enabling
In-Reply-To: <15108.1529795694@warthog.procyon.org.uk>
Message-ID: <alpine.DEB.2.21.1806240226370.8650@nanos.tec.linutronix.de>
References: <alpine.DEB.2.21.1806231402500.8650@nanos.tec.linutronix.de> <cover.1529706536.git.reinette.chatre@intel.com> <15108.1529795694@warthog.procyon.org.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 24 Jun 2018, David Howells wrote:

> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> >  - Stick the struct into the local header file and not at some random place in
> >    the source.
> 
> Why?  It's only used in that one file.  There doesn't seem to be any
> particular need to share it around.

It's not in a global header. It's a local header exactly to stick stuff
like that into it.

> >  - Get rid of the fugly camel case
> 
> It's not camel case.  It's the name of the option it's encoding.  But if it
> makes you happy...

Well, the option name slipped through, but that doesn't make an excuse for
making the struct member equally ugly. 

Thanks,

	tglx