Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 23 Jun 2018 18:17:38 -0700
From:   Fenghua Yu <fenghua.yu@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@elte.hu>,
        "H. Peter Anvin" <hpa@linux.intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Alan Cox <alan@linux.intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Arjan van de Ven <arjan@infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [RFC PATCH 02/16] x86/split_lock: Handle #AC exception for split
 lock in kernel mode
Message-ID: <20180624011738.GI18979@romley-ivt3.sc.intel.com>
References: <1527435965-202085-1-git-send-email-fenghua.yu@intel.com>
 <1527435965-202085-3-git-send-email-fenghua.yu@intel.com>
 <alpine.DEB.2.21.1806212301590.1591@nanos.tec.linutronix.de>
 <20180623042033.GF18979@romley-ivt3.sc.intel.com>
 <alpine.DEB.2.21.1806231108540.8650@nanos.tec.linutronix.de>
 <20180623150521.GG18979@romley-ivt3.sc.intel.com>
 <alpine.DEB.2.21.1806240245160.8650@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1806240245160.8650@nanos.tec.linutronix.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 24, 2018 at 02:55:08AM +0200, Thomas Gleixner wrote:
> On Sat, 23 Jun 2018, Fenghua Yu wrote:
> > On Sat, Jun 23, 2018 at 11:17:03AM +0200, Thomas Gleixner wrote:
> > > On Fri, 22 Jun 2018, Fenghua Yu wrote:
> It's not treated as failure. The firmware simply does not have an handler
> for #AC installed and dies. I hope you yelled at the firmware people
> already.

I think firmware does handle the split lock in its #AC handler because
firmware shows the following log and system hangs:

!!!! IA32 Exception Type - 11(#AC - Alignment Check)  CPU Apic ID - 00000014!
!
ExceptionData - 00000000
EIP  - 6A9DB6C3, CS  - 00000010, EFLAGS - 00010006
...

> If that is a real wide spread issue in practice, then we might have to go
> for some ugly workarounds, but we won't find out when we add them
> upfront. So testing will show what's wrong in firmware land and we can
> handle it from there. It's a completely orthogonal issue and has nothing to
> do with the core functionality.

Sure

Thanks.

-Fenghua