Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp2613211imm; Sun, 24 Jun 2018 00:12:44 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJz9j/YZcvz3iVIxCIul/HbepH3JkyiJ1DzxTKefx23fvqQ8RA16Dlg/s6kA1WEwewZkNef X-Received: by 2002:a17:902:3343:: with SMTP id a61-v6mr7615704plc.241.1529824364307; Sun, 24 Jun 2018 00:12:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529824364; cv=none; d=google.com; s=arc-20160816; b=FYTPJ7u7TPHwTh7VJIBu/MHfmnIz+G2nsN4ltJw4yO3OjS2ADFV+KX2XxP07Y//yQI qvcAtxGVMZWzFbJIYKY/y3GsAhJ2YYokUS7595V6tOuT7ArKljsbIcjO3045JmqiyZu0 O5Og1TeBD3tJ6DhhX7tQsHRcEZyUtohk7rf0EATfDETXrBMNgLUcnzXMnD9ctRBSlJ9n SErfflKifBi/bnPXPandjVPhjZ7ZCaKjTQMi+Ju6djgENt1oZK0wZLVjNALOZ3+mvq+O ejzcBvei1slW7zEFgYtqhnFO68OdS1imylPYfRp9I4nWfgNSXXnBF081hOtidxJBa2j8 55/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=fJnpxvlHss854XTqSPUAAxz93Rfu1q6qJYVBHEIeCyI=; b=Lrb9ibhuRgz9oWIEXWPHoYhB4D/e/nW0kMQXWWR6w91YZcLENWzGyf4802NHn6XUUc MHX+lLfTPxeE1p/gYI3ez5wrVx8J1sFPtqPSNNE04RDBRp92sclUS+CnYeqbOFKITFWd PH0l4D2GQII6zPgdW2f8R2191Ds4j1dBCr8g6onXOPUmElGA8y7MsRkmsjNpH7z4GI3u Ww9PfM2MiM4QQ5cCJccE8H+isIKKAlpXtCHVK3IbLzIYVA6UtEavWH2jEWD650Pf3Cj7 G+27c1KYG2dibh8KGI8Tss+wvESPKc0IwPV+ZDs7Thk7XWKFkVfdUznq2l4Yyh1Hm2Fk F5fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qnhE+0vf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si11489546plj.386.2018.06.24.00.12.30; Sun, 24 Jun 2018 00:12:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=qnhE+0vf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700AbeFXHLM (ORCPT + 99 others); Sun, 24 Jun 2018 03:11:12 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:43440 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbeFXHLK (ORCPT ); Sun, 24 Jun 2018 03:11:10 -0400 Received: by mail-wr0-f195.google.com with SMTP id p14-v6so1657680wrq.10; Sun, 24 Jun 2018 00:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fJnpxvlHss854XTqSPUAAxz93Rfu1q6qJYVBHEIeCyI=; b=qnhE+0vfMxH9DZYHwXw4OssKh9WJzUpUC/VDbcHg0R3+NOwyrzxoarB3DtbrkwHpM4 hDWuXOyOtPHgL80AwPmCjSO86IDuELEfYsIooyD3bkkVkcaUrBKcheF+Col/LPSH5vBi tNujHLRBbBkRuve+5dsLLdKH/xoZiDq+nh71xZM1gGFUYd4EIHT9UKqIlqu9sUtbJtdj vRrGmEMZoE7QKL0fjAhLAyhZNxAMTUmosyZec+swF+5+WEShXPIGqiHCedzWJ68b8OM6 V8wC1Zbt6IYXLGjqvDtRHpu5bBZmUw2BnuzOoCP8PJ1UunvqolXKhFnyhfL5cPXXsxKM SOrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=fJnpxvlHss854XTqSPUAAxz93Rfu1q6qJYVBHEIeCyI=; b=OKceip303ETw0EEw8KD3WAhlKH9a5uG7hgClPoyG1OqJoTEsR02LrvEKWA9mkunAMy E5zJI69jq3WtHIFBEN+KKxsxOdX9YFQ3PoYClY4pstnuu0a403CnOVh0Xu/jGaGEWA+w HgKhKJcdVFPA4+tXEd2zEUwq4spH4McfL4Ga2MSP14V60MSNI8cDIuIdrUKvvb8uSSpR vHv+K7R7/3fX9gpLKMj+stZKAqNY37Owq75ni1oSikUn45GNy2RDGAbojKeQ7rvg8wWb 5olUJ+ub8EC6ofnfWXMXELOPEh3IvvDJfT6gGpVnLGK33yPbaVr7BcIL/gmM0Hrl+sP4 yq/g== X-Gm-Message-State: APt69E3RTx1fAApJRUw+lTxjeIq7xOmnXyUfe9GMadZcuFiKZ0sy53m2 r9o2uzb9pVqKHmqnDS40RQ4= X-Received: by 2002:adf:b219:: with SMTP id u25-v6mr6591495wra.1.1529824269160; Sun, 24 Jun 2018 00:11:09 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id g88-v6sm7811335wmc.27.2018.06.24.00.11.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Jun 2018 00:11:08 -0700 (PDT) Date: Sun, 24 Jun 2018 09:11:05 +0200 From: Ingo Molnar To: Borislav Petkov Cc: linux-crypto@vger.kernel.org, Mike Galbraith , Alexey Dobriyan , torvalds@linux-foundation.org, tglx@linutronix.de, jpoimboe@redhat.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits , Herbert Xu Subject: Re: [PATCH] x86/crypto: Add missing RETs Message-ID: <20180624071105.GA29407@gmail.com> References: <20180507213755.GA32406@avx2> <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180623103622.GA2760@zn.tnic> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > Lemme send a proper patch now... > > --- > From: Borislav Petkov > Date: Sun, 17 Jun 2018 13:57:42 +0200 > Subject: [PATCH] x86/crypto: Add missing RETs > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms > otherwise they run into INT3 padding due to > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions") > > leading to spurious debug exceptions. > > Mike Galbraith took care of all the remaining callsites. Note that 51bad67ffbce has been zapped because it caused too many problems like this, but the explicit RETs make sense nevertheless. When applying the patch please don't include the SHA1 of the non-upstream (and probably never-upstream) commit. Thanks, Ingo