Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 24 Jun 2018 15:32:49 +0100
From:   John Whitmore <arigead@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     John Whitmore <johnfwhitmore@gmail.com>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 3/8] staging: rtl8192u: User memset to initialize
 memory, instead of loop.
Message-ID: <20180624143243.uxxgdfe4pldgwlb3@xux707-tw>
References: <20180624095732.12082-1-johnfwhitmore@gmail.com>
 <20180624095732.12082-4-johnfwhitmore@gmail.com>
 <1ca5d94c5ef94930773c9f3d239e12862a65922d.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ca5d94c5ef94930773c9f3d239e12862a65922d.camel@perches.com>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 24, 2018 at 07:26:41AM -0700, Joe Perches wrote:
> On Sun, 2018-06-24 at 10:57 +0100, John Whitmore wrote:
> > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
> []
> > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> []
> > @@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
> >   */
> >  static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
> >  {
> > -	u8					i;
> > -
> >  	if (!pOperateMCS) {
> >  		IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n");
> >  		return false;
> > @@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
> >  		//legacy rate routine handled at selectedrate
> >  
> >  		//no MCS rate
> > -		for (i = 0; i <= 15; i++)
> > -			pOperateMCS[i] = 0;
> > +		memset(pOperateMCS, 0, 15);
> 
> Not the same code.
> 
> Loop is <= 15, so memset should use 16
> 

Arragghhhh! Thank you and thank you for spotting that. I'll reissue again. I
should have been more careful. Sorry.