Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <36befceb2334197cce5cd44a61f86f38b870d54c.camel@perches.com>
Subject: Re: [PATCH] staging: pi433: replace simple switch statements
From:   Joe Perches <joe@perches.com>
To:     Valentin Vidic <Valentin.Vidic@CARNet.hr>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Simon =?ISO-8859-1?Q?Sandstr=F6m?= <simon@nikanor.nu>,
        Marcus Wolf <linux@Wolf-Entwicklungen.de>,
        Luca =?ISO-8859-1?Q?S=F6the?= <luca@acul.me>,
        Marcin Ciupak <marcin.s.ciupak@gmail.com>,
        Michael Panzlaff <michael.panzlaff@fau.de>,
        Derek Robson <robsonde@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, Hugo Lefeuvre <hle@owl.eu.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Date:   Sun, 24 Jun 2018 08:26:32 -0700
In-Reply-To: <20180624094245.23741-1-Valentin.Vidic@CARNet.hr>
References: <20180624094245.23741-1-Valentin.Vidic@CARNet.hr>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 2018-06-24 at 11:42 +0200, Valentin Vidic wrote:
> Use const array to map switch cases to resulting values.

I suggest you make the const arrays the same type
as the argument in the function being called.

> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
[]
> @@ -111,27 +111,22 @@ static inline int rf69_read_mod_write(struct spi_device *spi, u8 reg,
>  
>  int rf69_set_mode(struct spi_device *spi, enum mode mode)
>  {
> -	switch (mode) {
> -	case transmit:
> -		return rf69_read_mod_write(spi, REG_OPMODE, MASK_OPMODE_MODE,
> -					   OPMODE_MODE_TRANSMIT);
[]
> +	static const int mode_map[] = {
> +		[transmit] = OPMODE_MODE_TRANSMIT,
> +		[receive] = OPMODE_MODE_RECEIVE,
> +		[synthesizer] = OPMODE_MODE_SYNTHESIZER,
> +		[standby] = OPMODE_MODE_STANDBY,
> +		[mode_sleep] = OPMODE_MODE_SLEEP,
> +	};
[]
> +	return rf69_read_mod_write(spi, REG_OPMODE, MASK_OPMODE_MODE,
> +				   mode_map[mode]);

drivers/staging/pi433/rf69.c:static inline int rf69_read_mod_write(struct spi_device *spi, u8 reg,
drivers/staging/pi433/rf69.c-                                 u8 mask, u8 value)

so u8 here.

etc...