Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3572219imm; Mon, 25 Jun 2018 00:27:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKw6VnpVWXbA2Cnx+fWqIhxot67IWz/W1/hz4ZXq4W4SqnguM2724/v50+S5oEFIzVKnFOE X-Received: by 2002:a65:44c3:: with SMTP id g3-v6mr9665393pgs.231.1529911637242; Mon, 25 Jun 2018 00:27:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529911637; cv=none; d=google.com; s=arc-20160816; b=J3MIn4koGrCANX5DfALqSK2O0v2row39nB5xVeqLZj1oJiGUPaPTJlNJRRd3QX2OGR e8u6ip6JInAV9jRdcMLQTNEvtR4G0tO3bbyAlZjh8LUX7XaySzNGzmi4djYKiwWFm9dq RHoDY4V8gLVsTyaHKMWbFUmECeAUNFAlj8jpm+QaQYhUmCUgdr4cJNwnrLqLGt2duHJD VcK1kqXWXT4f5lSRBGYw30nCkVnKJCMFRHk7YcSoCElLDjcQ0q5+EtwIuOk3d13Cx2BR +hu7a0g3ZuLRxJ1qrICO2a8Ni3j+ReWmkrhh2ec5Ui0cIUmAfoJV+R8ywjjMtltPD7/w U4jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=uOTQYQa8K4kzhU9jNZET3iWzo0h6B0N16fLmsOgI28k=; b=EpE9gH4b0agjx9jQnUS0VbEN9aW7+Hi3UzhTprZY+QLKlH1Eo0AMoKewHyZbMGRTqZ CvwUY9gpc7TpXqPGFYtNrjldKFKMv4zFtyBOMYtCfqmQrzoM5hkEOYTFH0imFgMFXQ3K XXDqskvqvPJGAtshX30toXb6XysGQW9ZyuUlSFvLKxgoW2If+eg8wfV+h3v+VJfiMmwv kEt1ua5R0ISPI7FO6CuU9RVqX+0/cTUZmypLlyM6aPHW2lPCEZdzV8Jy+/N1BvyCaqmS f7QL6vVHNXZoaSn34tOzXKPCsEmQfYON5HXtfaEWcQ080GFlnmQHNCjRq6ajIwMwxNHt l4HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=kGNm8KM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1-v6si11365241pgs.221.2018.06.25.00.27.02; Mon, 25 Jun 2018 00:27:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=kGNm8KM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbeFYHYq (ORCPT + 99 others); Mon, 25 Jun 2018 03:24:46 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:37913 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbeFYHYn (ORCPT ); Mon, 25 Jun 2018 03:24:43 -0400 Received: by mail-wm0-f68.google.com with SMTP id 69-v6so8696808wmf.3; Mon, 25 Jun 2018 00:24:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uOTQYQa8K4kzhU9jNZET3iWzo0h6B0N16fLmsOgI28k=; b=kGNm8KM+sWTOJXQUTeuw2dUAsP88afOYLMJqMIhvtkfSdX92LfzriwGLHrGpeb8/Ve 3PkdBVHWU+Pu5hGOXgee4TJ2AlBVq2TLOQzOO7XrqgNbQd1fXIh5GcxlKu0AIuobBFZG PjWzXkrM0bUbNG0/YBym6Y8fKleGic7UUSMkmxoNYwz0IE5Yt85ZqKEOv8SY6zRt6A5P LKMxnR8irUOOB62cHlLeeu9HDHgnEosY887/dIEDnOaqGcQI4MyjtHUWp+TMlE4PwbHR es6jAP9fQj9YSAQRGsLoBLSJUJmmt8ZRcHPRZN1fqqU1b3W9+m1UTQRYhTnhwASC0i5A 3bxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=uOTQYQa8K4kzhU9jNZET3iWzo0h6B0N16fLmsOgI28k=; b=NeNB0bhRaTVB19KSVyg1Ab6wqGD2IlOJgGvt9DX7j1p3eQNKVf+59pI39OKXc/0Wgj XyIWQ7RorjVhasCwcATG1YbFY0lxFVtA4KSyDRqBAHL/TLIVdculjY/sAsHeA8bwe/a8 KWUNjEhLQIcRv48IdqReu8hAzZsanTSjSvkTgAMSdPNV6JTiPEtFWYhnJFketR5OGXR7 cxcy8XV4XyCEOhCSl9IrGYMmBzQrQgX4dMi/VR0IvhwXdHDFV3jhKbeljKC52BGj/6Gk yLFPWsiXCSB/1GldzqLBPIR2zRf1klTNf/tBUVEFDGkKah49TvhA0g6fVcBncOgaGwNh 8MDg== X-Gm-Message-State: APt69E3Uy9e+8gf+ykep11WKMSx7rSybYZiXSTXqslnusR6eAU3JUwfL X+XDRVuEB4owWjKSpFpCJIY= X-Received: by 2002:a1c:e48a:: with SMTP id b132-v6mr7160wmh.129.1529911482008; Mon, 25 Jun 2018 00:24:42 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id m145-v6sm8422126wma.19.2018.06.25.00.24.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 00:24:41 -0700 (PDT) Date: Mon, 25 Jun 2018 09:24:38 +0200 From: Ingo Molnar To: Alexey Dobriyan Cc: Borislav Petkov , linux-crypto@vger.kernel.org, Mike Galbraith , torvalds@linux-foundation.org, tglx@linutronix.de, jpoimboe@redhat.com, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits , Herbert Xu , Peter Zijlstra Subject: Re: [PATCH] x86/crypto: Add missing RETs Message-ID: <20180625072438.GA19063@gmail.com> References: <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com> <20180624104449.GA20159@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180624104449.GA20159@avx2> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexey Dobriyan wrote: > On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote: > > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms > > > otherwise they run into INT3 padding due to > > > > > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions") > > > > > > leading to spurious debug exceptions. > > > > > > Mike Galbraith took care of all the remaining callsites. > > > > Note that 51bad67ffbce has been zapped because it caused too many problems like > > this, but the explicit RETs make sense nevertheless. > > So commit which found real bug(s) was zapped. > > OK No, what happened is that the commit was first moved into WIP.x86/debug showing its work-in-progress status, because it was incomplete and caused bugs: https://lore.kernel.org/lkml/20180518073644.GA8593@gmail.com/T/#u ... and finally, after weeks of inaction I zapped it because I didn't see progress and you didn't answer my question. If a fixed patch with updated tooling to detect these crashes before they occur on live systems is submitted we'll reconsider - it didn't get NAK-ed, it's just incomplete in the current form. Thanks, Ingo