Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usb: xhci: dbc: Don't decrement runtime PM counter if DBC
 is not started
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>,
        mathias.nyman@intel.com
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20180625052004.15298-1-kai.heng.feng@canonical.com>
From:   Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <59b5789b-a33d-6a61-af53-dc6feba8951f@linux.intel.com>
Date:   Mon, 25 Jun 2018 11:25:59 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180625052004.15298-1-kai.heng.feng@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25.06.2018 08:20, Kai-Heng Feng wrote:
> pm_runtime_put_sync() gets called everytime in xhci_dbc_stop().
> 
> If dbc is not started, this makes the runtime PM counter incorrectly
> becomes 0, and calls autosuspend function. Then we'll keep seeing this:
> [54664.762220] xhci_hcd 0000:00:14.0: Root hub is not suspended
> 
> So only calls pm_runtime_put_sync() when dbc was started.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, nice catch.
Adding to queue

-Mathias