Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262057AbTIJLCd (ORCPT ); Wed, 10 Sep 2003 07:02:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262076AbTIJLCd (ORCPT ); Wed, 10 Sep 2003 07:02:33 -0400 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.202.12]:63719 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id S262057AbTIJLCb (ORCPT ); Wed, 10 Sep 2003 07:02:31 -0400 Date: Wed, 10 Sep 2003 13:02:25 +0200 From: Adrian Bunk To: Eyal Lebedinsky Cc: Kernel Mailing List , Russell King Subject: [patch] 2.6.0-test5: serio config broken? Message-ID: <20030910110225.GC27368@fs.tum.de> References: <3F5DBC1F.8DF1F07A@eyal.emu.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F5DBC1F.8DF1F07A@eyal.emu.id.au> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2626 Lines: 76 On Tue, Sep 09, 2003 at 09:40:15PM +1000, Eyal Lebedinsky wrote: >... In -test4 I have: > > CONFIG_SERIO=m > CONFIG_SERIO_I8042=m > CONFIG_SERIO_SERPORT=m > CONFIG_SERIO_CT82C710=m > CONFIG_SERIO_PARKBD=m > CONFIG_SERIO_PCIPS2=m > > but -test5 insists on: > > CONFIG_SERIO=m > CONFIG_SERIO_I8042=y > CONFIG_SERIO_SERPORT=m > CONFIG_SERIO_CT82C710=m > CONFIG_SERIO_PARKBD=m > CONFIG_SERIO_PCIPS2=m > > Removing the I8042 line and doing 'make oldconfig' does not even > ask about it but sets it to '=y'. As a result I get: > > LD init/built-in.o > LD .tmp_vmlinux1 > drivers/built-in.o: In function `atkbd_interrupt': > drivers/built-in.o(.text+0x6d10f): undefined reference to `serio_rescan' > drivers/built-in.o: In function `atkbd_disconnect': > drivers/built-in.o(.text+0x6d726): undefined reference to `serio_close' > drivers/built-in.o: In function `atkbd_connect': > drivers/built-in.o(.text+0x6d84e): undefined reference to `serio_open' > drivers/built-in.o(.text+0x6d883): undefined reference to `serio_close' > drivers/built-in.o: In function `atkbd_init': > drivers/built-in.o(.init.text+0x5fd6): undefined reference to > `serio_register_de > vice' > drivers/built-in.o: In function `atkbd_exit': > drivers/built-in.o(.exit.text+0x196): undefined reference to > `serio_unregister_d > evice' > make: *** [.tmp_vmlinux1] Error 1 The patch below should fix it. cu Adrian --- linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig.old 2003-09-04 19:03:45.000000000 +0200 +++ linux-2.6.0-test4-mm5-modular-no-smp/drivers/input/keyboard/Kconfig 2003-09-04 19:04:49.000000000 +0200 @@ -13,7 +13,8 @@ config KEYBOARD_ATKBD tristate "AT keyboard support" if EMBEDDED || !X86 - default y + default y if INPUT=y && INPUT_KEYBOARD=y && SERIO=y + default m depends on INPUT && INPUT_KEYBOARD && SERIO help Say Y here if you want to use a standard AT or PS/2 keyboard. Usually --- linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig.old 2003-09-10 12:52:22.000000000 +0200 +++ linux-2.6.0-test5+tr-modular-no-smp/drivers/input/serio/Kconfig 2003-09-10 12:52:47.000000000 +0200 @@ -20,7 +20,8 @@ config SERIO_I8042 tristate "i8042 PC Keyboard controller" if EMBEDDED || !X86 - default y + default y if SERIO=y + default m depends on SERIO ---help--- i8042 is the chip over which the standard AT keyboard and PS/2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/