Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Jun 2018 12:17:13 +0300
From:   Ilias Apalodimas <ilias.apalodimas@linaro.org>
To:     Petr Machata <petrm@mellanox.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        jiri@mellanox.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        "David S. Miller" <davem@davemloft.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs
Message-ID: <20180625091713.GA13442@apalos>
References: <20180624153339.13572-1-f.fainelli@gmail.com>
 <wih4lhrgrfd.fsf@dev-r-vrt-156.mtr.labs.mlnx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <wih4lhrgrfd.fsf@dev-r-vrt-156.mtr.labs.mlnx>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 25, 2018 at 12:13:10PM +0300, Petr Machata wrote:
> Florian Fainelli <f.fainelli@gmail.com> writes:
> 
> >  	if (netif_is_bridge_master(vlan->obj.orig_dev))
> > -		return -EOPNOTSUPP;
> > +		info.port = dp->cpu_dp->index;
> 
> The condition above will trigger also when a VLAN is added on a member
> port, and there's no other port with that VLAN. In that case the VLAN
> comes without the BRIDGE_VLAN_INFO_BRENTRY flag. In mlxsw we have this
> to get the bridge VLANs:
> 
> 	if (netif_is_bridge_master(orig_dev)) {
> 		[...]
> 		if ((vlan->flags & BRIDGE_VLAN_INFO_BRENTRY) &&
> 		[...]
> 
> This doesn't appear to be done in DSA unless I'm missing something.
Petr's right. This will trigger for VLANs added on 'not cpu ports' if the VLAN
is not already a member. 

This command has BRIDGE_VLAN_INFO_BRENTRY set:
bridge vlan add dev br0 vid 100 pvid untagged self 
I had the same issue on my CPSW RFC and solved it
exactly the same was as Petr suggested.

> 
> Thanks,
> Petr

Regards
Ilias