Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Jun 2018 12:46:18 +0100
From:   John Whitmore <arigead@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     John Whitmore <johnfwhitmore@gmail.com>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding
 Style
Message-ID: <20180625114617.l4uc7c6k3gxd5tks@xux707-tw>
References: <20180624153454.27356-1-johnfwhitmore@gmail.com>
 <20180624153454.27356-8-johnfwhitmore@gmail.com>
 <ed1a3747023af619d547e1ef7d593fd25b3abcb7.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ed1a3747023af619d547e1ef7d593fd25b3abcb7.camel@perches.com>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 24, 2018 at 08:59:22AM -0700, Joe Perches wrote:
> Rather than doing individual patches for each line
> with a whitespace issue, I think it'd be better to
> do a single driver wide patch.
> 
> Perhaps use a tool like:
> 
> $ git ls-files drivers/staging/rtl8192u |
>   xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing
> 
> where:
> 
> $ git diff -w drivers/staging/rtl8192u/
> 
> should not show a single difference.
> 
> Then compile and commit that as a single patch with
> something like "use a more typical spacing style"
> as the commit message.
> 

Thank you for that command. Hadn't found the "--types=spacing" option.

I'd fixed all the spacing issues in that file in a previous patch set. That
space issue was in a commented out section of code, which is why I missed it
previously. I think that file has all space issues cleared so there's only the
single fix in this patch.