Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180621081704.GA677@jagdpanzerIV>
References: <20180620125540.228766-1-dvyukov@gmail.com> <CAHp75VdR_gDBk7v9WDN1fHc=1q=j2mx3CkTz83SZZWm=pbnczA@mail.gmail.com>
 <CACT4Y+bjdmgdeRLM5kBaf6-vunFwFRD0_zCZX=A-rY+XEEfnEA@mail.gmail.com> <20180621081704.GA677@jagdpanzerIV>
From:   Dmitry Vyukov <dvyukov@google.com>
Date:   Mon, 25 Jun 2018 14:40:00 +0200
Message-ID: <CACT4Y+ZZVOjec2dvRCU9p7MHkbYyjqk7FMr4Yu3ahVyL_g0YGQ@mail.gmail.com>
Subject: Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()
To:     Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Dmitry Vyukov <dvyukov@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 21, 2018 at 10:17 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> On (06/21/18 09:59), Dmitry Vyukov wrote:
>> >
>> >> +       printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
>> >> +               (address < PAGE_SIZE ? "NULL pointer dereference" :
>> >> +               "paging request"), (void *) address);
>> >
>> > Perhaps pr_alert() ?
>>
>> It's the same, right? Make sense.
>
> Right.
>
> In printk(KERN_<LEVEL> ...) people tend to forget KERN_<LEVEL> sometimes,
> so, I think, in general we want to see more pr_foo() and less printk().

Mailed v2 with pr_alert().

Since nobody else commented on single pr_alert() with ternary operator
vs if + 2 pr_alert()'s, I left it intact for now.