Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3885069imm; Mon, 25 Jun 2018 06:18:05 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKAojPE84+MBEYu+iOx+tjQ9sKvn0ZzbwYYHyaeIjbWOBbuSWKr8kgkjvndbnj5zEY4oP5D X-Received: by 2002:a63:8749:: with SMTP id i70-v6mr6842706pge.325.1529932685754; Mon, 25 Jun 2018 06:18:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529932685; cv=none; d=google.com; s=arc-20160816; b=kMq3x0E71E9sfZTFVaU+UIjJVqwbKYa6jCnYT0H9XkJ4xDApoPZAowPN+56sLIjw+G ppcj+RW5OYrEa8XODB0iZnM5NwOLsHDKm62GXtwJcDbCajpJqt3QSxB5gUGUE9VlcZcW esms553e1yxFUhRvojyYqJkAhQ+pJD93Vs/e2lhgdNlwHP3QagqWKQ0OAIw3WDAKV/Df LU9VjfFdcTaVLmr1JRcshNIBdCK7XPhn6BU3vMUNCxwKl+oLy4BNz1NXgTqLQj6BQqpu u74rkMqdHvs67SlYhTHrDydXLddIa+qdkIEboFH492UtZOR9sLQokpwVagdiToMoFENX 6lDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=eE9EEfSGEbamL3wkTV8Xua3YnUDrBuxr0r/+1bsJ2eg=; b=uCCvhQ55VJKZfmKsLrF9ddCUdsDezBb5i8rqBOsEPUK6gKHfP8ZYpvMXjixeAPI6S1 zPGt/1sK4RrmNt0TA+GIlMAtUlQIHzuj3hyokYY01LQm7YjoeGP2DKKYKHZdSYAn+7cr bFmcBLTUNXPkM32UQDwUI5WlAra48UMvOaMXgUHf94fjJLzrDHty2cCjjb2v9KiZcheR Kk8xAnHhu9KNegmoE8t1Lj1EUPN9xf7IKlLxmeCR8J5nT0U92negv19oJ3YWfCHzXqPY AOXWuJ/XST368lZm2ZDf8Fkcnd6Nhvt8C9MI4IUBmgO4C7rMeHioIXS3S1IeL1KujkiI c58w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11-v6si11818588pgc.97.2018.06.25.06.17.51; Mon, 25 Jun 2018 06:18:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934017AbeFYNQr (ORCPT + 99 others); Mon, 25 Jun 2018 09:16:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:48788 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933730AbeFYNQp (ORCPT ); Mon, 25 Jun 2018 09:16:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7CCCBABDF; Mon, 25 Jun 2018 13:16:44 +0000 (UTC) Date: Mon, 25 Jun 2018 15:16:44 +0200 (CEST) From: Jiri Kosina To: Zhouyang Jia cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: hid-ntrig: add error handling for sysfs_create_group In-Reply-To: <1528983437-52903-1-git-send-email-jiazhouyang09@gmail.com> Message-ID: References: <1528707296-35785-1-git-send-email-jiazhouyang09@gmail.com> <1528983437-52903-1-git-send-email-jiazhouyang09@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jun 2018, Zhouyang Jia wrote: > When sysfs_create_group fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling sysfs_create_group. > > Signed-off-by: Zhouyang Jia > --- > v1->v2: > - Remove goto statement. Applied, thanks. -- Jiri Kosina SUSE Labs