Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3887633imm; Mon, 25 Jun 2018 06:20:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLeOXlYQ9bRrTTUWTZ4ZSjFEx9L30QmWIhlRxXDJs9x/8BQuGUOwk4uiaJDzNJ+sf33rGFl X-Received: by 2002:a17:902:8549:: with SMTP id d9-v6mr12555698plo.81.1529932833167; Mon, 25 Jun 2018 06:20:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529932833; cv=none; d=google.com; s=arc-20160816; b=hbLiExPZxZ/Kq/NWF3bwzfe18UVRFN8qqjCc2RrsZubS9a/hr/SjQz7EL1D/OSA+kX r/8NuWqVLTv1OPoMVJda0cFBOhwUvEjHrgbbHQFLEy/rNHa7FqUfy/4NOKa+T0DD9icE JH0fsU0acqWatJ2KlYDDs9JvmXoUC4wP8+e6tdMbdVFkvs/S5nLQd9iCSrm1QZR+2YQ7 jnSzmoiJLA9gBrBZGQ0Cw03urYTvepSvXXQUKMtk8B1LQg/uRqgEzblgrNkuW4am1NRW F++tPGfyjOL4l1JjGA6k3pSV2TNmHtZs67QYsZmlQufNQzY/+IOrsqYvRz0+8oyEZ1G0 uFFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=re3IyRolFpVaoU6I9z+ITVqnPRqVMoaHmRNcYQyjCK4=; b=tmNscpcnT5g5WG9t1ipkKahLLkkPPqe2kBxbiPy2h0dTvUBuwdwT8nXhpjIJbg9ZxU 6nfI8wPV6i5JiqIbKB7QlyOuyJSNkzf+QMGntqXfNpBeXuXvv8VwkqD6jE41CqtwjTQn JbFMe4NOQgHu5t2gkKENi1KQhAnH+2nE1rVi6nBJHI8+ejyk6ipxEzq/ZohrKT0FHfFw h0RCj7md0DSV8oC7f4yee8ea+gvAqZofBXn8PE3tjYNMZpibBcVXl02ikF2zvzM7cwJ+ N6sznYKyadWrLzJ8CJ2V1dvTpspVXpnRF4Xs/5Vb5tYnf+xsZB2xgTpvSoU6fvUqvTzb E/sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d5-v6si13959205plr.13.2018.06.25.06.20.18; Mon, 25 Jun 2018 06:20:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933785AbeFYNTi (ORCPT + 99 others); Mon, 25 Jun 2018 09:19:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754582AbeFYNTh (ORCPT ); Mon, 25 Jun 2018 09:19:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4C9497C6A9; Mon, 25 Jun 2018 13:19:36 +0000 (UTC) Received: from treble (ovpn-123-175.rdu2.redhat.com [10.10.123.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30C352166B5D; Mon, 25 Jun 2018 13:19:34 +0000 (UTC) Date: Mon, 25 Jun 2018 08:19:32 -0500 From: Josh Poimboeuf To: Ingo Molnar Cc: Alexey Dobriyan , Borislav Petkov , linux-crypto@vger.kernel.org, Mike Galbraith , torvalds@linux-foundation.org, tglx@linutronix.de, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits , Herbert Xu , Peter Zijlstra Subject: Re: [PATCH] x86/crypto: Add missing RETs Message-ID: <20180625131932.sge43esxdb5ejoxg@treble> References: <1529235613.4572.7.camel@gmx.de> <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com> <20180624104449.GA20159@avx2> <20180625072438.GA19063@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180625072438.GA19063@gmail.com> User-Agent: NeoMutt/20180323 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 25 Jun 2018 13:19:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 25 Jun 2018 13:19:36 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jpoimboe@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 09:24:38AM +0200, Ingo Molnar wrote: > > * Alexey Dobriyan wrote: > > > On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote: > > > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms > > > > otherwise they run into INT3 padding due to > > > > > > > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions") > > > > > > > > leading to spurious debug exceptions. > > > > > > > > Mike Galbraith took care of all the remaining callsites. > > > > > > Note that 51bad67ffbce has been zapped because it caused too many problems like > > > this, but the explicit RETs make sense nevertheless. > > > > So commit which found real bug(s) was zapped. > > > > OK > > No, what happened is that the commit was first moved into WIP.x86/debug showing > its work-in-progress status, because it was incomplete and caused bugs: > > https://lore.kernel.org/lkml/20180518073644.GA8593@gmail.com/T/#u > > ... and finally, after weeks of inaction I zapped it because I didn't see progress > and you didn't answer my question. > > If a fixed patch with updated tooling to detect these crashes before they occur on > live systems is submitted we'll reconsider - it didn't get NAK-ed, it's just > incomplete in the current form. Hm, what happened to the objtool patch to detect these at build time? Did it not work? https://lore.kernel.org/lkml/20180517134934.eog2fgoby5azq5a7@treble -- Josh