Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3897362imm; Mon, 25 Jun 2018 06:30:32 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKRUV5VwoijcNhxRgULxfAV72pcItbbaPAaOwrX0ZHxkni/G5njSLibsk2pJA98/O1t0Euw X-Received: by 2002:a17:902:a9:: with SMTP id a38-v6mr12698423pla.102.1529933432874; Mon, 25 Jun 2018 06:30:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529933432; cv=none; d=google.com; s=arc-20160816; b=yt/J8pQCRpp3sM9ZK6SvOgw6ohkdryx4sVL8uxa6p8jsh+U9YgasbjNaxScg36he2j Nx7m+YUsDXVgcSsHjiOSedaUpjVCGi51UoPT7/H4q21sGm5JMD+3PGcJ1C7qdwEQf9+u M2Wq8BeT694xg8XmOgRFDYaFzVJxyTMhS7hfwtgRLlG5gRjIbGmyCw0EoqqOsEzYUurt Jb/Fzr8yelzQZebIyFzMAylhO6AfMlIJi8AmBw+rFGPeIIw6iX/QUT3TPXJizTDToeo1 GOKfbwzQAKm0gyL8ot5KEoo/AWQd7HS2zyNWgwcW2gl3oYqKxVNsGCmZ76L2G0SZ+zP8 SU4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :mime-version:dkim-signature:arc-authentication-results; bh=VoF7uPmjIBf11HPtLKAwFxbjtVOFysmGXONtW6WV4HQ=; b=mD+MM/lpqBTjkFaYbPvf520LkBjoU49YZZ4qffvVhlY4kxb6UkZmrvasjg6Zm7uyvM kh5/rgTeCx5ebzrVaLwYDkdUfLiACJ2erntlgtvHg2XPF9gADVVeixKgKt4/tgcz3CqN u+92Zb1tlFBj9dL4iFPaiejhCVtDEH2B4sB744knPBlhYYJeAfd0h0/nTErbwZfLPc58 FDhWowiMufG31k9Fj3H3hLNG9IXnruuNEobGO5s/09hazJqOFh9BRqYSiRL+yv5KpHzo PcITYw5qACTxYl33CbukbAqQw2wtBKsV6czjtnZYiV6904r+wA4XlyFpjGV43Q+7YOGG le2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qAerjVjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l123-v6si14329362pfc.32.2018.06.25.06.30.17; Mon, 25 Jun 2018 06:30:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=qAerjVjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755578AbeFYN3b (ORCPT + 99 others); Mon, 25 Jun 2018 09:29:31 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:34187 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755484AbeFYN33 (ORCPT ); Mon, 25 Jun 2018 09:29:29 -0400 Received: by mail-wr0-f196.google.com with SMTP id a12-v6so13715639wro.1 for ; Mon, 25 Jun 2018 06:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=VoF7uPmjIBf11HPtLKAwFxbjtVOFysmGXONtW6WV4HQ=; b=qAerjVjBEl1zhQquuvJa0C/YAg5RGt9drNrt0LsSjY44vWIfQJO0umSvitlyUMlS63 vN/ko2L43FdPCN8iUsb8L0niT1RVB9HU/uYJK1CsoRpBVI7fZoe6yvDszaTLei8pqvVI Yg0o2bPiuJN5S13bOX9wvVTZ/yit58TURuMEs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=VoF7uPmjIBf11HPtLKAwFxbjtVOFysmGXONtW6WV4HQ=; b=fzVcuOjiyd2+LiGBe8bIiuew93MbbbLiK6V3oYL9uvYkvcbfOB2HY1MzUASVzdCftW Szc+9lxkdRSduuqFNkP40JrhbhifnDr4B8JPc5g+tDQFLM5BLdCnit9Avbef06pR8zXV 4KSrSu247C6DF/ESU+kJPsWKMBB8av5IeCT6Qh7iU1e1pdeVIPwrAofkV1eY3+QV98GM AF8Ebub1MPTZDnoqmTGZ6Hs2cvMD/w9AXi2EyxreT9Bk147A0EYoInC1/TSFAcJuRYbF xo+WZGH19LaXkRxqyfyqQA4E4bqspt6aG3FePcp119wk6Vj4zdqu74yYe+XX4VWF89AG ru/g== X-Gm-Message-State: APt69E0kWGA5pQBnn7cxy0hTTXSosg7p1N8Vmw0JF8Jdz8Zl+iQ25heh 25hC5JcKMwqMM+8xokYxHoTE/MXNoGBXJPforwLNB+ktmQU= X-Received: by 2002:adf:90af:: with SMTP id i44-v6mr6744230wri.146.1529933368487; Mon, 25 Jun 2018 06:29:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:8684:0:0:0:0:0 with HTTP; Mon, 25 Jun 2018 06:29:27 -0700 (PDT) From: Michael Nazzareno Trimarchi Date: Mon, 25 Jun 2018 15:29:27 +0200 Message-ID: Subject: simple-framebuffer enquire To: Hans de Goede Cc: Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hans In order to let it even registered the simplefb I have added this change. According on what I understand from the code seems that this is the way to acquire memory with the correct attribute diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c index a3c44ec..7e61ce3 100644 --- a/drivers/video/fbdev/simplefb.c +++ b/drivers/video/fbdev/simplefb.c @@ -466,8 +466,8 @@ static int simplefb_probe(struct platform_device *pdev) info->fbops = &simplefb_ops; info->flags = FBINFO_DEFAULT | FBINFO_MISC_FIRMWARE; - info->screen_base = ioremap_wc(info->fix.smem_start, - info->fix.smem_len); + info->screen_base = arch_memremap_wb(info->fix.smem_start, + info->fix.smem_len); if (!info->screen_base) { ret = -ENOMEM; goto error_fb_release; Another question is aliases { display0 = &lcdif; }; chosen { #address-cells = <1>; #size-cells = <1>; ranges; stdout-path = &uart1; framebuffer0: framebuffer@86fd6080 { compatible = "simple-framebuffer"; reg = <0x86fd6080 (480 * 272 * 4)>; width = <480>; height = <272>; stride = <(480 * 4)>; format = "a8r8g8b8"; clocks = <&clks IMX6UL_CLK_LCDIF_PIX>, <&clks IMX6UL_CLK_LCDIF_APB>, <&clks IMX6UL_CLK_DUMMY>, <&clks IMX6UL_CLK_GPIO3>, <&clks IMX6UL_CLK_GPIO4>; nshut-supply = <®_lcd_nshut>; nreset-supply = <®_lcd_nreset>; display = <&lcdif>; }; }; }; How do you ensure that regulators that are bind to gpios can be maintain during boot? A small minor comment is how to automatic switch then to normal framebuffer. Anyway seems that #address-cells = <1>; #size-cells = <1>; ranges; are mandatory and they are in the dts documentation. Best regards Michael