Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp3948079imm; Mon, 25 Jun 2018 07:17:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKpYWHZD2hDxaTTeARVLVZFb6jWb4mGttiLuAuRH9J4873mhFkfIkGVe5H6NtgdsnJzLowk X-Received: by 2002:a17:902:722:: with SMTP id 31-v6mr12952280pli.3.1529936245398; Mon, 25 Jun 2018 07:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529936245; cv=none; d=google.com; s=arc-20160816; b=u3wmr0XCtPUeGDnZymPZlJ7npp0w1qRW1GjKI4JCnkaeUA0OWX1JJDgrwt7CnXeqOA KTOCNimVvfkak+BplruoRkXHGyhOx7vOkvZkjYgFxCRO8T5VmDp1x6Kba1cXgF8x/gE8 i0AfuJndI0SvwZmyeciJ+ECtFpxcyzNfvlt/3fQOAejRj0IYVZAym8bBRvGvCV8yZtDf q6g+ij0fxiorZn5oWpzrynjLZOmR129D4JJnJIQMGmYRWKwrAlfK+5Qhppe2OOsEGz8O NiHLAOHePMCRws8Lal+7kOOSIFCYIpzBtvtLjJsNUdxg9jnUjEzHkXptqdmFo0JGefJP E7ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=TtiWMRAFfPq53Z1DVBNzSn1010VnKr5+X2x1e9orG6I=; b=rv8RMKzFhUobDOxYMhIcjQQ4xFGO05K+7SylOr9WHxzAuRr7+X+WDCR1HQ5Z0ufvSL NNwXoKTGivHOE69Qot/xbcMIRdP2/Dlh3SUAiaTCHIyr1ek11XoSUWnb4gbXfhS6l0Il T9OBBPaVnN34llO6nH268N4nqZJirTwaFda4RUUEhJEtD5cXHrm8F9j/iCFD7fRVoSft xXwJzNDqFOvjyJwDND3knknhKIpwaCVIxWFdtbP5uylfmfAkuUZ4jsq+hNGfEwkMqGWC EpXHARA0bFLfbO0+d+2FGm/hYDzwK+mCUkJaTpw6fF81zFS7QN3pAmVYRgnVe+SzZodk Jhjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d64-v6si5381756pfc.31.2018.06.25.07.17.10; Mon, 25 Jun 2018 07:17:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934315AbeFYOQM (ORCPT + 99 others); Mon, 25 Jun 2018 10:16:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:34152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934184AbeFYOQK (ORCPT ); Mon, 25 Jun 2018 10:16:10 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B3B225B35; Mon, 25 Jun 2018 14:16:09 +0000 (UTC) Date: Mon, 25 Jun 2018 10:16:07 -0400 From: Steven Rostedt To: Masahiro Yamada Cc: Greg Thelen , Andi Kleen , Linux Kernel Mailing List , X86 ML , Linux Kbuild mailing list , Andrew Morton , Andi Kleen , Michal Marek Subject: Re: [PATCH] trace: fix SKIP_STACK_VALIDATION=1 build Message-ID: <20180625101607.08db48ff@gandalf.local.home> In-Reply-To: References: <20180608214746.136554-1-gthelen@google.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 23 Jun 2018 02:42:26 +0900 Masahiro Yamada wrote: > 2018-06-09 6:47 GMT+09:00 Greg Thelen : > > Non gcc-5 builds with CONFIG_STACK_VALIDATION=y and > > SKIP_STACK_VALIDATION=1 fail. > > Example output: > > /bin/sh: init/.tmp_main.o: Permission denied > > > > commit 96f60dfa5819 ("trace: Use -mcount-record for dynamic ftrace"), > > added a mismatched endif. This causes cmd_objtool to get mistakenly > > set. > > > > Relocate endif to balance the newly added -record-mcount check. > > > > Fixes: 96f60dfa5819 ("trace: Use -mcount-record for dynamic ftrace") > > Signed-off-by: Greg Thelen > > --- > > Applied to linux-kbuild/fixes. Thanks! > > I already pushed this to Linus. As I was the one to mess it up in the first place ;-) (I think I applied it with some fuzz) https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ed7d40bc67b8353c677b38c6cdddcdc310c0f452 -- Steve