Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Jun 2018 17:04:22 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Mukesh Ojha <mojha@codeaurora.org>
cc:     john.stultz@linaro.org, linux-kernel@vger.kernel.org,
        neeraju@codeaurora.org, gkohli@codeaurora.org,
        cpandya@codeaurora.org
Subject: Re: [PATCH v2] time: Fix sleeptime injection for non-stop clocksource
 & persistent clock
In-Reply-To: <e869c2ec-90fa-27e2-975c-a92469f56dac@codeaurora.org>
Message-ID: <alpine.DEB.2.21.1806251701410.1821@nanos.tec.linutronix.de>
References: <1527680699-16068-1-git-send-email-mojha@codeaurora.org> <alpine.DEB.2.21.1806222312340.1589@nanos.tec.linutronix.de> <e869c2ec-90fa-27e2-975c-a92469f56dac@codeaurora.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 25 Jun 2018, Mukesh Ojha wrote:
> On 6/23/2018 2:57 AM, Thomas Gleixner wrote:
> > @@ -1671,7 +1685,6 @@ void timekeeping_resume(void)
> >   	struct timespec64 ts_new, ts_delta;
> >   	u64 cycle_now;
> >   -	sleeptime_injected = false;
> >   	read_persistent_clock64(&ts_new);
> >     	clockevents_resume();
> > @@ -1743,6 +1756,8 @@ int timekeeping_suspend(void)
> >   	if (timekeeping_suspend_time.tv_sec ||
> > timekeeping_suspend_time.tv_nsec)
> >   		persistent_clock_exists = true;
> >   +	sleeptime_injected = false;
> 
> I did not get the exact valid point of moving it from `timekeeping_suspend` to
> `timekeeping_resume`.

It's the other way round. I move it from resume to suspend. Simply because
it should only be set to 'false' when suspend is reached. It would work the
other way round as well, but I felt it's inconsistent.

Thanks,

	tglx