Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180625155750.GA14306@jordon-HP-15-Notebook-PC>
In-Reply-To: <20180625155750.GA14306@jordon-HP-15-Notebook-PC>
From:   Andy Lutomirski <luto@amacapital.net>
Date:   Mon, 25 Jun 2018 09:11:36 -0700
Message-ID: <CALCETrU3dS5t714BYqkxEYgkbJaESK6NP1Rsn3xq3En38yjJzQ@mail.gmail.com>
Subject: Re: [PATCH] x86/vdso: Change return type to vm_fault_t for fault handlers
To:     jrdr.linux@gmail.com
Cc:     Matthew Wilcox <willy@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, brajeswar.linux@gmail.com,
        sabyasachi.linux@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 25, 2018 at 8:55 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.

Whoa there..  Your commit message makes it sound like you're just
changing the return type, but:

>                 if (tsc_pg && vclock_was_used(VCLOCK_HVCLOCK))
> -                       ret = vm_insert_pfn(vma, vmf->address,
> +                       ret = vmf_insert_pfn(vma, vmf->address,
>                                             vmalloc_to_pfn(tsc_pg));
>         }
>
> -       if (ret == 0 || ret == -EBUSY)
> -               return VM_FAULT_NOPAGE;
> -
> -       return VM_FAULT_SIGBUS;
> +       return ret;

You're refactoring the code, too.

Please fix your changelog.