Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp4096283imm; Mon, 25 Jun 2018 09:38:44 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL0b2YD1IZQ8qsgQp5fV+wKHPNHuiwRwZhBrtsD0YRkB/fctmz42YiTS/YDWqOq8ZBI1A2c X-Received: by 2002:a65:420d:: with SMTP id c13-v6mr11353502pgq.265.1529944724114; Mon, 25 Jun 2018 09:38:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529944724; cv=none; d=google.com; s=arc-20160816; b=f9Cqx5ceh9uS+1EoeV6MHkJFNZU6BYgWITfhfmZ9+wU7ExNNPsAEFE99dH2pYM3tn1 B2zkx/CasNveXir3Tj0Fwmhw0mJWhLZfnyIy7APJSvlfsRO/5z54ga1aMkO+sXJtpfti nFlaE69RUsJT19fPu7OmG+wrb5ZaszlIhQd3zLGPtUbhvf5WQJ5m2zEpbIt43T/sqYDj q2A2zwP97wJX76U6TQggNp4iahNXYSt13v1/zkKGGKTd4yyLRMs9iahJA+My8LpbCE9Z /5vDnsICyr9X8GLWslt0APqTi/akV8b8Lugsl4OGzc9R0O6yFESqoqp87iKAbf+w6qdg MPNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:cc:references:to:subject :arc-authentication-results; bh=ZnGlHe+VVi20hOObUYYppWrkJIqlDZZINIkATIlcOrk=; b=aHNfxX5sasNrtg7ejkx9InCkFYtCqfOjUYMUDEjizp9gWUCgL7eqr/oD9dSpj3cAO4 XRwQpnOcXUY73Oe5EhtAzi21Yvm7XHRbGtmXNUX+2gIxpAFFnwuBPxvxdzva0RyImSpC sQIqQKAxwYr7aralHV7VVbDU5D0o95OZNa1Ewh1BL8BNDutPbZvlbMdWR9QD4M+w7dVB k38HDqDB9a58Xd/nygi1W3DTL+pwdlIYiyPQ6SjGekn/XjWv9qcM8mBXhi0DImb49XVG K6NzpGOWF1W/lLwGgGE8v7rbttAJIzjBY7gNSGgNoh5El643o4fVRSYV7HzItGBwz41v t5Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5-v6si14990825pfb.244.2018.06.25.09.38.19; Mon, 25 Jun 2018 09:38:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754423AbeFYQgr (ORCPT + 99 others); Mon, 25 Jun 2018 12:36:47 -0400 Received: from mga01.intel.com ([192.55.52.88]:22807 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbeFYQgp (ORCPT ); Mon, 25 Jun 2018 12:36:45 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2018 09:36:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,270,1526367600"; d="scan'208";a="52124320" Received: from ray.jf.intel.com (HELO [10.7.201.18]) ([10.7.201.18]) by orsmga008.jf.intel.com with ESMTP; 25 Jun 2018 09:36:44 -0700 Subject: Re: [PATCHv3 15/17] x86/mm: Implement sync_direct_mapping() To: "Kirill A. Shutemov" References: <20180612143915.68065-1-kirill.shutemov@linux.intel.com> <20180612143915.68065-16-kirill.shutemov@linux.intel.com> <848a6836-1f54-4775-0b87-e926d7b7991d@intel.com> <20180625092937.gmu6m7kwet5s5w6m@black.fi.intel.com> Cc: Ingo Molnar , x86@kernel.org, Thomas Gleixner , "H. Peter Anvin" , Tom Lendacky , Kai Huang , Jacob Pan , linux-kernel@vger.kernel.org, linux-mm@kvack.org From: Dave Hansen Openpgp: preference=signencrypt Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <0ac027dd-ca4b-316e-ee2c-64305e633b1b@intel.com> Date: Mon, 25 Jun 2018 09:36:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180625092937.gmu6m7kwet5s5w6m@black.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/2018 02:29 AM, Kirill A. Shutemov wrote: > On Mon, Jun 18, 2018 at 04:28:27PM +0000, Dave Hansen wrote: >>> >>> remove_pagetable(start, end, true, NULL); >>> + ret = sync_direct_mapping(); >>> + WARN_ON(ret); >>> } >> >> I understand why you implemented it this way, I really do. It's >> certainly the quickest way to hack something together and make a >> standalone piece of code. But, I don't think it's maintainable. >> >> For instance, this call to sync_direct_mapping() could be entirely >> replaced by a call to: >> >> for_each_keyid(k)... >> remove_pagetable(start + offset_per_keyid * k, >> end + offset_per_keyid * k, >> true, NULL); >> >> No? > > Yes. But what's the point if we need to have the sync routine anyway for > the add path? Because you are working to remove the sync routine and make an effort to share more code with the regular direct map manipulation. Right? My point is that this patch did not even make an _effort_ to reuse code where it would have been quite trivial to do so. I think such an effort needs to be put forth before we add 400 more lines of page table manipulation. >>> int __ref arch_remove_memory(u64 start, u64 size, struct vmem_altmap *altmap) >>> @@ -1290,6 +1295,7 @@ void mark_rodata_ro(void) >>> (unsigned long) __va(__pa_symbol(rodata_end)), >>> (unsigned long) __va(__pa_symbol(_sdata))); >>> >>> + sync_direct_mapping(); >>> debug_checkwx(); >> >> Huh, checking the return code in some cases and not others. Curious. >> Why is it that way? > > There's no sensible way to handle failure in any of these path. But in > remove path we don't expect the failure -- no allocation required. > It can only happen if we missed sync_direct_mapping() somewhere else. So, should we just silently drop the error? Or, would it be sensible to make this a WARN_ON_ONCE()?