Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp4506832imm; Mon, 25 Jun 2018 17:34:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJlF2Wo7W02dzMFJWzZg+7lAp32v7mR/oQJ+yRPp2CtDM06seu7QOHVTvv0DLcx6bFX6ogo X-Received: by 2002:a65:620b:: with SMTP id d11-v6mr1396123pgv.429.1529973265837; Mon, 25 Jun 2018 17:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529973265; cv=none; d=google.com; s=arc-20160816; b=TEalD82gebSok3BZT80f8TGr9SRdV9RipvzHUR4/vZYMtWtL5Yitrv518UeML8NtiD ZPFIo8OptCREFMlTKUAd5NS9SYLfWdZ5K3M9CvGYKZYFb6sD8FYPjqsOM49yrzdNYexw ZTAUV0pA/9GN/uSyay+2bhf+8fM43jR3KVv86CmWJoxpHR/WC3SzkfEI2g8V7fdJ5Zcv psRaA7zTVdA76P7v8vNd/ZW1cmrZBfSb1wG6uWtgZlgkPnqzUOLaOGbcW9rwkPGraUYd WZ7tQztZC/uFGGXBReGpfSR1PnW94Rq+/NqhAR+SHv19SYCu+zxxZUP8J5bbzftQteMz H1bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=7MlSQmGvmWA7ovn/n9hLhojR+V07S3453bodacRGR9I=; b=UXpX16ku14nXG1MjZWoRfqMAJL8Y89X+MbnHbCQ2J4XkB3UmP6+KORZC13/T6kEnN6 PX3NWUrNZna4/yeTBtU5VnR7RnTuaMTOExzmLk8zOL8oTOGj56/ZW47XedxjCqiiuyWZ wKck6aowlFltPAZ3M/HjHmNUj8jZ+XQB23EyvFQL4EU3pUPM0l9rrXHe6tvf9+aoAj5X 6iNW+7y6e7fhsa1pK5KTUEcrWkx82rhg6izNAu9oQgk4Ig05utd3HdB1RgGruewLrtUe xHS6sXrM++e49OwB6Ky7itcXLOHoCIErHT7UxgKllHy7h5Mvb45yUlNZnG+d8wnxwJ8p 17uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l80-v6si301379pfj.188.2018.06.25.17.34.11; Mon, 25 Jun 2018 17:34:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934905AbeFZAdW (ORCPT + 99 others); Mon, 25 Jun 2018 20:33:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36364 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934573AbeFZAdR (ORCPT ); Mon, 25 Jun 2018 20:33:17 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5Q0SfaP140934 for ; Mon, 25 Jun 2018 20:33:16 -0400 Received: from e14.ny.us.ibm.com (e14.ny.us.ibm.com [129.33.205.204]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ju96rbd04-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 25 Jun 2018 20:33:16 -0400 Received: from localhost by e14.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Jun 2018 20:33:15 -0400 Received: from b01cxnp23033.gho.pok.ibm.com (9.57.198.28) by e14.ny.us.ibm.com (146.89.104.201) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 25 Jun 2018 20:33:11 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5Q0XAYb8258030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Jun 2018 00:33:10 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD6F0B2067; Mon, 25 Jun 2018 20:33:04 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A3855B205F; Mon, 25 Jun 2018 20:33:04 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 25 Jun 2018 20:33:04 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id E002C16CA09C; Mon, 25 Jun 2018 17:35:14 -0700 (PDT) From: "Paul E. McKenney" To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 10/27] rcu: Remove unused local variable "cpu" Date: Mon, 25 Jun 2018 17:34:56 -0700 X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180626003448.GA26209@linux.vnet.ibm.com> References: <20180626003448.GA26209@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18062600-0052-0000-0000-00000304097E X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009255; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01052336; UDB=6.00539469; IPR=6.00830262; MB=3.00021856; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-26 00:33:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062600-0053-0000-0000-00005D23DD8F Message-Id: <20180626003513.27812-10-paulmck@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-25_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=973 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806260005 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org One danger of using __maybe_unused is that the compiler doesn't yell at you when you remove the last reference, witness rcu_bind_gp_kthread() and its local variable "cpu". This commit removes this local variable. Signed-off-by: Paul E. McKenney --- kernel/rcu/tree_plugin.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index 75a91d58b8f7..2cc9bf0d363a 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h @@ -2670,8 +2670,6 @@ static bool rcu_nohz_full_cpu(struct rcu_state *rsp) */ static void rcu_bind_gp_kthread(void) { - int __maybe_unused cpu; - if (!tick_nohz_full_enabled()) return; housekeeping_affine(current, HK_FLAG_RCU); -- 2.17.1