Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265002AbTIJPcG (ORCPT ); Wed, 10 Sep 2003 11:32:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264998AbTIJPcF (ORCPT ); Wed, 10 Sep 2003 11:32:05 -0400 Received: from [63.205.85.133] ([63.205.85.133]:33526 "EHLO gaz.sfgoth.com") by vger.kernel.org with ESMTP id S265002AbTIJPaI (ORCPT ); Wed, 10 Sep 2003 11:30:08 -0400 Date: Wed, 10 Sep 2003 08:38:16 -0700 From: Mitchell Blank Jr To: Matthew Wilcox Cc: Marc Zyngier , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Move EISA_bus Message-ID: <20030910153816.GA84652@gaz.sfgoth.com> References: <20030909222937.GH18654@parcelfarce.linux.theplanet.co.uk> <20030910114749.GR18654@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030910114749.GR18654@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 937 Lines: 20 Matthew Wilcox wrote: > On Wed, Sep 10, 2003 at 07:31:23AM +0200, Marc Zyngier wrote: > > While we're at it, why not setting EISA_bus as 'deprecated', so people > > will know they'd better move the driver to the EISA probing API ? > > I'd rather not. It'll cause warnings in arch code that's making > perfectly legitimate use of it, eg arch/i386/kernel/traps.c that sets > it or arch/parisc/kernel/pci.c that keys off EISA_bus to know whether > to direct port access to the EISA or PCI bus adapters. Perhaps put the "depreciated" tag inside an "#ifdef MODULE" so the warnings will show up in allmodconfig at least. Or are there any modules that have a legitimate use for EISA_bus? -Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/