Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180625170913.p335obgr3rfa4skt@flea>
References: <20180622160631.8578-1-icenowy@aosc.io> <20180622160631.8578-2-icenowy@aosc.io>
 <20180625170913.p335obgr3rfa4skt@flea>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Tue, 26 Jun 2018 11:17:30 +0800
Message-ID: <CAGb2v65HJKm3UhA1bPZxg7+KL_FAHO+LDx4ijzXasS-K0UGUXQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: allwinner: a64: allow laptops to wake up from lid
To:     Icenowy Zheng <icenowy@aosc.io>
Cc:     Maxime Ripard <maxime.ripard@bootlin.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        devicetree <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 26, 2018 at 1:09 AM, Maxime Ripard
<maxime.ripard@bootlin.com> wrote:
> On Sat, Jun 23, 2018 at 12:06:31AM +0800, Icenowy Zheng wrote:
>> Currently all ARM kernels will have s2idle enabled if CONFIG_SUSPEND is
>> present. In this case if the lid is closed, systemd-logind will enter
>> s2idle mode by default; however there's no possible wakeup source
>> defined, so the system will enter a forever idle.
>>
>> Add the lid itself as a wakeup source, thus the system can wakeup when
>> the lid is opened.
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>
> Applied both, thanks!
> Maxime

Icenowy, could you also look into having the power button as a wakeup source?
It has no device node, so you might have to look at how to implement it in
the driver.

ChenYu