Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp4732523imm; Mon, 25 Jun 2018 22:56:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIu2obPI7R7HIoLVI6l2jH+/fWcPVvH8WWjMQzGYLxfl9SaVhmif/LQVci24LO7aCRXyvhm X-Received: by 2002:a17:902:a505:: with SMTP id s5-v6mr177787plq.66.1529992576290; Mon, 25 Jun 2018 22:56:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529992576; cv=none; d=google.com; s=arc-20160816; b=KFlXKPvJ4E1GUViBe4BnCbNz18/+hSxXIJ73UxxUjfsKbdgsTkbVfPqpvsjf4yGL+0 FtWuB+bKClnRk5Qe6t/6uFXP9be8os7TM39NJ8GiS2zYgPVKXkWBarmUyG2ycjLiVck6 ElYzjZULDP6dFsOzD8svkEZZuZ0l5ghsgOGFv/K8KZ6ZRYDSm/okN9uNQ+GzIGZgQ9bA IBm2mB6840MusrFVmQniobygAGnhk/wKp1+S/SikCzU2LYWUJVAb3jgvmFwVq37y8eOs 80bP5v2B6nhFI0zZJRlbK8v+N5eAF2iE/xdQBww30ObM+8pikZaatcmm4VFlEq7KpONi 41BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:header:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=UHPEllSQYFKxvcYeXIgaCXU9HVWUgVnf+JIaMbumtoM=; b=gJr2fcMSkPQJIOjgr5TrmmUtHpgkwex8lmMlCxxcThHGc2m+ftNEuokZyfJvTHDd86 i92nom/YiNdHg+ZXRxXF2aNs6t467unaLSBZ1b6mFT/JYFgSYP40+hHqrpUnHZ19fSYZ aTSL2hNvu7Q6q59gRLi2I4rM8WDod8035yz/nWrpueWPlqLJ718OID4AZGwRf2dqnmVN 8kik1+2iS5d2MUe5+sk7/xxjVCH6rwJv7BkTje0UmRH89xkmyGQFFQaARSX8kQMUlGoD Ki+f29xY9q0056a5pL6+wVQQ0H0dTuIt6m96ew2krMYODGv5qJL4S7h3revjMu0oralw XN9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3-v6si995257plk.47.2018.06.25.22.56.00; Mon, 25 Jun 2018 22:56:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751043AbeFZFzW (ORCPT + 99 others); Tue, 26 Jun 2018 01:55:22 -0400 Received: from cannabis.dataforce.net ([195.42.160.49]:38546 "EHLO cannabis.dataforce.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbeFZFzV (ORCPT ); Tue, 26 Jun 2018 01:55:21 -0400 X-Greylist: delayed 1351 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Jun 2018 01:55:20 EDT Received: by cannabis.dataforce.net (Postfix, from userid 12794) id 2CD7F4A0004; Tue, 26 Jun 2018 08:32:48 +0300 (MSK) Date: Tue, 26 Jun 2018 08:32:46 +0300 From: Georgi Guninski To: Christian Borntraeger Cc: Guenter Roeck , Martin Schwidefsky , Vasily Gorbik , Heiko Carstens , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-s390x , qemu-devel , Cornelia Huck , Thomas Huth Subject: Re: s390 qemu boot failure in -next Message-ID: <20180626053246.6kyvrj7jbuhgdkgv@sivokote.iziade.m$> References: <20180622194736.GA5794@roeck-us.net> <126ac556-0602-b927-58f5-cb5f65a5e0ec@de.ibm.com> <88d9afed-f91d-c320-13c8-9a93fc52b700@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88d9afed-f91d-c320-13c8-9a93fc52b700@de.ibm.com> header: best read with a sniffer Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 25, 2018 at 09:27:59AM +0200, Christian Borntraeger wrote: > - /* Overwrite parameters in the kernel image, which are "rom" */ > - strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); > + strcpy(rom_ptr(KERN_PARM_AREA), ipl->cmdline); Why not replace strcpy() with strncpy() or snprintf()? strcpy() may overflow.