Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp4775624imm; Mon, 25 Jun 2018 23:51:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJyhNkHZdIr9iGlOazPb6UsakMhbIyV1xkJ8FeXk9Li6oJwxL2Gk1gaPgcIFdu6tAgZwP2V X-Received: by 2002:a65:6290:: with SMTP id f16-v6mr248384pgv.155.1529995864446; Mon, 25 Jun 2018 23:51:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529995864; cv=none; d=google.com; s=arc-20160816; b=pGOC237HIqFOE/puI1HJnCM2Bc/dJFV9bygobZz3hO0RxNmQh4IW3hV1FI5N4c5eTh 9JkLgZczqbeCG3zI/n42hI3iF6zghpF868drBT7lPsu+Yiaj1FaTZmR3KvWZU0pXQPSU 7xRumIdpk53a8sr/2mXV6KIdBSzrQUFWk3B+m7ELYUhL2owxeAlcjWh1+RY4t1w89oHH Mksw6HugwJRBzY+es6gsQMIz6K7Rzn+5C3oyuEPq2WQ1IKuuRnOibjN3I6dvFuzBYZP9 VmcTpja4EXeBwJVc1U43xg1SFA/ZKHl/Z0GWLXmFjveipR2jPrxMuDpA5Gg7B9kxhvyh CzMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=8BUtu2CN80g81knJE6Ebusy5tFXC3/NCEIOM92toX3k=; b=tO+P4Qz6bs3Vr5fLAGD1uiZOh76GGp3wXKppx43spw5ok+3g9nA/1hJYCv28mz5DAp g3aq9Jeb2fmATBjYhF3sWzj4MajeXzfRuBLRxr+B1pSZXircuxhQpMpCMN64PDL/1qi7 VPzxTY9HJkK5z/xqDzPt8n5ALatd+HWALYrUWrtSrGDQVrjewx2SMaRPHZ5WMccjIfz6 FzAI+Ck1y3JEzmPeCmNjaxpWL83WQ5iEvCJSDwI1MmwUnUQI/eC6y4/zzxOYOl/pvmU3 d5p5TPirNk89Ezrj1+/Kx+1SQ7HzD8ywA/JSXwmrh0hSMLGNsRTrHagZtZXI5oQT1sDT 4byQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=h7s1Z9qJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3-v6si787768pgv.573.2018.06.25.23.50.49; Mon, 25 Jun 2018 23:51:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=h7s1Z9qJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbeFZGti (ORCPT + 99 others); Tue, 26 Jun 2018 02:49:38 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41621 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbeFZGtf (ORCPT ); Tue, 26 Jun 2018 02:49:35 -0400 Received: by mail-wr0-f196.google.com with SMTP id h10-v6so15951492wrq.8; Mon, 25 Jun 2018 23:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8BUtu2CN80g81knJE6Ebusy5tFXC3/NCEIOM92toX3k=; b=h7s1Z9qJ7EieINKMxVITcs9QrxPAlGFXQI6e1R621Zq973Kd2ZniD/VEYXWgN8cuE9 qzSIOAwIvH3hRaVUurAsg12K2f86vBDM8rZeuURNQPS1T+cqwW48RrcK4QoVeD5gJVFh sGmNG2YgsMPS3jo/Q4ebGlNbOKS9ROB9jte2vzTLQ8ZUURGt7eyAJqNXeadciZ7TDv7h 504cGT1NZexpU4B2041gz8BnLjMSMwo1guNBXW59S7B2a52vQ57Pewx6qbSVdayrk2oh osPON3Zon9wnSb7gD4ZRbDhoVAZ1h9GkOgX9uwbvOt9k6Y6t6PQjiTnySB0XjbzFc5VT b5ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=8BUtu2CN80g81knJE6Ebusy5tFXC3/NCEIOM92toX3k=; b=cWpIcctrMRXIaGZ/z0WVc6KfBGo+u+bad4PYdDr6QL8GzgATtOEsULSEiwLXmBZBMR ATxSXyaOnoufqugMIpAWLkOlnfpOx68qaNreE1jV7XcxN36hzO1G8Gufmnv/ttiANCt6 rqoeSjjHl9MiIFtAEqkynNxlUM4/7EedCv2uO1hMucV4QLkpCguWOhfdPly/dX9qlEIY 0ahjUaCWBUaWWOILDcUmoNKazvObDPwGUJ4jnwstarntI/wJ9MAiWlXuMt3uFkhpmnQZ oWvczarl/aL1y5Ivu4BxyQQXquDjO6qDxhdmI72UANkOwKJhJRczpn8giGuMNGkM6zyD dW6g== X-Gm-Message-State: APt69E22qwdzemQ5PUnnnBmK2tMBbYtlxHbFXqbmhaQWKyhnokHANsZe SNoMwHZQW8MiBjtdD8mlAps= X-Received: by 2002:adf:f482:: with SMTP id l2-v6mr251455wro.259.1529995773848; Mon, 25 Jun 2018 23:49:33 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id z5-v6sm782567wrh.10.2018.06.25.23.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Jun 2018 23:49:33 -0700 (PDT) Date: Tue, 26 Jun 2018 08:49:30 +0200 From: Ingo Molnar To: Josh Poimboeuf Cc: Alexey Dobriyan , Borislav Petkov , linux-crypto@vger.kernel.org, Mike Galbraith , torvalds@linux-foundation.org, tglx@linutronix.de, luto@kernel.org, peterz@infradead.org, brgerst@gmail.com, hpa@zytor.com, linux-kernel@vger.kernel.org, dvlasenk@redhat.com, h.peter.anvin@intel.com, linux-tip-commits , Herbert Xu , Peter Zijlstra Subject: Re: [PATCH] x86/crypto: Add missing RETs Message-ID: <20180626064930.GB25879@gmail.com> References: <20180617120012.GB16877@zn.tnic> <1529242717.4472.3.camel@gmx.de> <1529244178.4674.1.camel@gmx.de> <20180617194747.GA21160@zn.tnic> <1529289279.31745.3.camel@gmx.de> <20180623103622.GA2760@zn.tnic> <20180624071105.GA29407@gmail.com> <20180624104449.GA20159@avx2> <20180625072438.GA19063@gmail.com> <20180625131932.sge43esxdb5ejoxg@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180625131932.sge43esxdb5ejoxg@treble> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Josh Poimboeuf wrote: > On Mon, Jun 25, 2018 at 09:24:38AM +0200, Ingo Molnar wrote: > > > > * Alexey Dobriyan wrote: > > > > > On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote: > > > > > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms > > > > > otherwise they run into INT3 padding due to > > > > > > > > > > 51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions") > > > > > > > > > > leading to spurious debug exceptions. > > > > > > > > > > Mike Galbraith took care of all the remaining callsites. > > > > > > > > Note that 51bad67ffbce has been zapped because it caused too many problems like > > > > this, but the explicit RETs make sense nevertheless. > > > > > > So commit which found real bug(s) was zapped. > > > > > > OK > > > > No, what happened is that the commit was first moved into WIP.x86/debug showing > > its work-in-progress status, because it was incomplete and caused bugs: > > > > https://lore.kernel.org/lkml/20180518073644.GA8593@gmail.com/T/#u > > > > ... and finally, after weeks of inaction I zapped it because I didn't see progress > > and you didn't answer my question. > > > > If a fixed patch with updated tooling to detect these crashes before they occur on > > live systems is submitted we'll reconsider - it didn't get NAK-ed, it's just > > incomplete in the current form. > > Hm, what happened to the objtool patch to detect these at build time? > Did it not work? > > https://lore.kernel.org/lkml/20180517134934.eog2fgoby5azq5a7@treble So that's still incomplete in that doesn't analyze the 32-bit build yet, right? Thanks, Ingo