Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5248672imm; Tue, 26 Jun 2018 08:12:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe4tKRfUiswQr6ZAzyy3s156Hzhb3UQ95o/YhNAyxH7HuhnwlUDNmiH0By20oeonvgkgTCX X-Received: by 2002:a62:234a:: with SMTP id j71-v6mr1911153pfj.221.1530025942485; Tue, 26 Jun 2018 08:12:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530025942; cv=none; d=google.com; s=arc-20160816; b=OtuhI3PablIgY5ptENlA0b6y4/LKtn+Ecz02u3IkWZQW3m8vnNZqT3PvFc5RaQpcN+ Yd9CsXcI0g6RNR23AkhOba0j8MzPPZjFEt/F3TLG+H7XhQzGmBMqq94uc85a4p7U9SUZ 3eHE2Td06B5WKiPj6Xjy2qwgiF1+S7urJkYRUWJhnASY8ivPB0hG6BrcvHxGWXz1uaDo iwuauaHLJOGD0psPWL50iUAE/peUU4PN82V30XhunpUJ07Q+e0olap0H8veQSAyjcwR7 QfC0Eovk5wewhcCGzpHm0gARCe0XZHBZGlj7U1MDVRSydEvTrXy8AfIdJhDKr/tZUAau ygRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature:arc-authentication-results; bh=hXeQTsftg/ujeoqU+9+BMl97T/64o+Z0tP/57HYzYSM=; b=jEKFOMVgV0eC2PDbiMZryjHc/SezWPSJxRtCUaFPOBKGm3VTNUr8FHnWanR5QgLdhQ quLPzBJxEKhG7vvRVuoAt0NKE8M9EbLOlHdJGky7cPlZiWZavO9ke9cEHNEeMFNJB2Qk FUnFIfRkA7LCTU5cwyXmihXux4a+eNED7iZcIxAs+h4k9W1/rz9+DuXAkf/uPTIaz9fR FoAe2To/foIVBaoTovEuIL7ZMIjK0VfF0p1cQfzYXkGUijSMkDlu/5bwIKcAyEpVAidz /Qv0zFPiUnXaQcGIw/J39jtJMaD9aKArtw5nHiBpKX+NTWYsJWqvgqXcwss7EWEWA6HV gSQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=US6CNBN9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l4-v6si1734383plt.497.2018.06.26.08.12.07; Tue, 26 Jun 2018 08:12:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=US6CNBN9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbeFZPLU (ORCPT + 99 others); Tue, 26 Jun 2018 11:11:20 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49950 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbeFZPLQ (ORCPT ); Tue, 26 Jun 2018 11:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=hXeQTsftg/ujeoqU+9+BMl97T/64o+Z0tP/57HYzYSM=; b=US6CNBN9VuUW WEQSuJBi5ihuDxh3Zjxhm7l+XOtEdBMQPGqr4xIusMQGCt1xPazF2JGI0lbh+2Einrou4L+yYDNWD 46DkifUUj1Xh/tN85ZaBoUu3vPYQfFGmvBPnnVu1bGbxWzAYsLXEqQCqRZKn/tzl1KnnXwLZPp/zg 9ElH8=; Received: from host109-146-194-33.range109-146.btcentralplus.com ([109.146.194.33] helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXpcb-0001KY-OK; Tue, 26 Jun 2018 15:11:09 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 43C44440070; Tue, 26 Jun 2018 16:11:09 +0100 (BST) From: Mark Brown To: Srinivas Kandagatla Cc: Niklas Cassel , Mark Brown , broonie@kernel.org, robh+dt@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, tiwai@suse.com, linux-arm-kernel@lists.infradead.org, niklas.cassel@linaro.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: qdsp6: q6asm: use of_platform_populate/depopulate()" to the asoc tree In-Reply-To: <20180626092016.9296-6-srinivas.kandagatla@linaro.org> Message-Id: <20180626151109.43C44440070@finisterre.ee.mobilebroadband> Date: Tue, 26 Jun 2018 16:11:09 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: qdsp6: q6asm: use of_platform_populate/depopulate() has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 4aac7e2773030d667491fbb6d97c9f467fdcbc05 Mon Sep 17 00:00:00 2001 From: Srinivas Kandagatla Date: Tue, 26 Jun 2018 10:20:09 +0100 Subject: [PATCH] ASoC: qdsp6: q6asm: use of_platform_populate/depopulate() Now that the child nodes have there own compatible strings, Use of_platform_populate/depopulate() instead of less common of_platform_device_create()/destroy(). Signed-off-by: Srinivas Kandagatla Acked-by: Niklas Cassel Signed-off-by: Mark Brown --- sound/soc/qcom/qdsp6/q6asm.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index 530852385cad..c4fd28f168d5 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -177,7 +177,6 @@ struct q6asm { struct platform_device *pcmdev; spinlock_t slock; struct audio_client *session[MAX_SESSIONS + 1]; - struct platform_device *pdev_dais; }; struct audio_client { @@ -1344,7 +1343,6 @@ EXPORT_SYMBOL_GPL(q6asm_cmd_nowait); static int q6asm_probe(struct apr_device *adev) { struct device *dev = &adev->dev; - struct device_node *dais_np; struct q6asm *q6asm; q6asm = devm_kzalloc(dev, sizeof(*q6asm), GFP_KERNEL); @@ -1359,22 +1357,12 @@ static int q6asm_probe(struct apr_device *adev) spin_lock_init(&q6asm->slock); dev_set_drvdata(dev, q6asm); - dais_np = of_get_child_by_name(dev->of_node, "dais"); - if (dais_np) { - q6asm->pdev_dais = of_platform_device_create(dais_np, - "q6asm-dai", dev); - of_node_put(dais_np); - } - - return 0; + return of_platform_populate(dev->of_node, NULL, NULL, dev); } static int q6asm_remove(struct apr_device *adev) { - struct q6asm *q6asm = dev_get_drvdata(&adev->dev); - - if (q6asm->pdev_dais) - of_platform_device_destroy(&q6asm->pdev_dais->dev, NULL); + of_platform_depopulate(&adev->dev); return 0; } -- 2.17.1