Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Jun 2018 15:56:28 +0100
Message-ID: <86efgt7g0z.wl-marc.zyngier@arm.com>
From:   Marc Zyngier <marc.zyngier@arm.com>
To:     Laurentiu Tudor <laurentiu.tudor@nxp.com>
Cc:     <tglx@linutronix.de>, <jason@lakedaemon.net>,
        <linux-kernel@vger.kernel.org>, <Minghuan.Lian@nxp.com>,
        <Zhiqiang.Hou@nxp.com>
Subject: Re: [PATCH] irqchip/ls-scfg-msi: update effective affinity mask
In-Reply-To: <20180626143712.30489-1-laurentiu.tudor@nxp.com>
References: <20180626143712.30489-1-laurentiu.tudor@nxp.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Organization: ARM Ltd
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 26 Jun 2018 15:37:12 +0100,
Laurentiu Tudor <laurentiu.tudor@nxp.com> wrote:
> 
> Update the effective affinity mask to fix this warning issued by the
> generic irq handling code:
> 
> "genirq: irq_chip MSI did not update eff. affinity mask of irq x"
> 
> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> ---
>  drivers/irqchip/irq-ls-scfg-msi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
> index 1ec3bfe56693..d81d5b016438 100644
> --- a/drivers/irqchip/irq-ls-scfg-msi.c
> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
> @@ -122,6 +122,7 @@ static int ls_scfg_msi_set_affinity(struct irq_data *irq_data,
>  	}
>  
>  	cpumask_copy(irq_data->common->affinity, mask);
> +	irq_data_update_effective_affinity(irq_data, mask);
>  
>  	return IRQ_SET_MASK_OK;
>  }

It has already been addressed here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=893fbfff976cd069f2e60c3b186dbe3f85504db2

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.