Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5442837imm; Tue, 26 Jun 2018 11:17:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeZvMQF7Wf3VdA+OlIalSMlS/lb1VZbKXMV2v0IxNyByOGVNZNn3MW/RhR9tn/dm09hss4J X-Received: by 2002:a63:9a52:: with SMTP id e18-v6mr1419791pgo.188.1530037037105; Tue, 26 Jun 2018 11:17:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530037037; cv=none; d=google.com; s=arc-20160816; b=aqsiagPqthm17rCCfNmLvLFttv+NlfybsNd7dpuXAWYb+ARDT9szGCm6o5/8UgNkOp URwmK67uOwh6Y5VA5ZtjDlYQX4xkMyyKY/ygb71dmvDuus0oetILI3KFRWmf6LXFakE7 fMe3Ywr9gH7eslz+0u1MQ/XaHSv2XTMni5B6X80P5+UGbAcuVjFPyMtAgA08awJ1j78b V0Xc1Z5W4nWQ/rPITyFpNZ7KsOmOh88aLiXtYiMcAkw3/51I6tdflaS3ozAU6gDkVuEW juAqsYZT6nJbo9daBfrSDyFmQblgLs5j/k1aMom0lHVb0sm8ukB7vqZKHsBGWC6maVCY 85Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=TU7YPeB8u9a/+uEXgGW/SXplYVc2tIbi4l/A6Ccfwew=; b=XmD3ODIZTx4JTrfoMtXVsRLXC6B00hOGFyxZRP+Y1UZ8tfD+s3Tx5kYCHiHSClJB7m F3mCteL7jRJjncNPXwnEpCQuWC7R7Fxnj4R0FwL1/RYAcGhoY4+UZD5hDb46jB8AslQk eAp+sySCtk2lhQokrtq0f9XgH12HW/134ofJCSKeYUd/hlQHGc63KZLML/Fdym7NJNMD EYDmwgKhvRly9OkKwA5OxOQ3snV4c4jCgRHu0Muxmtcu3HxAZdCeBef0EKdwRKDkIUw/ peW2wHarHqXgwGEiInu1YB/qyS934w7e1fxz1oppwUwsqtRmWYlfv+rKZRw4WKjsMMjs 0Euw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=X1vebm+h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p16-v6si1821467pgc.204.2018.06.26.11.16.51; Tue, 26 Jun 2018 11:17:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=X1vebm+h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752711AbeFZQD0 (ORCPT + 99 others); Tue, 26 Jun 2018 12:03:26 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60830 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbeFZQDY (ORCPT ); Tue, 26 Jun 2018 12:03:24 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5QFsTN0149617; Tue, 26 Jun 2018 16:01:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=TU7YPeB8u9a/+uEXgGW/SXplYVc2tIbi4l/A6Ccfwew=; b=X1vebm+hARIV6ftB0f8YeBmyeUm5/o5PKXoD27fjaAqoSpwfTmkvV5r08TqMVIupZvI4 YYKqCB0ZV7lzXJ2k/2H+57o3Uwqk+JqSA+97rG99rV1dtPtJwceFmMD0czcCJa9JgUle R3sxrlIfAFkWpoIsPCdH01cJAXPoUZ3FSmDPl8BmDN9TG+qRkn0zk2Mzj/Urel53T2ia GAYXAbtvRwFoIjJYbLcbgzdnC2Fia7T+6oAE7rA63ZyfxltmfNz/JoJX8wkeR9Pmm60R DgUibMmb3vneqIUzXMLrwfu8PTNofXX+Szls7K4aGTn8KXHXgo5F640eSKO6vkenJOsB Ww== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2jum0a18g5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jun 2018 16:01:01 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5QG0wGQ003421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jun 2018 16:00:59 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w5QG0vw3003620; Tue, 26 Jun 2018 16:00:58 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Jun 2018 09:00:57 -0700 To: Arnd Bergmann Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , y2038@lists.linaro.org, Hannes Reinecke , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: lpfc: use monotonic timestamps for statistics From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180618152903.1756535-1-arnd@arndb.de> Date: Tue, 26 Jun 2018 12:00:54 -0400 In-Reply-To: <20180618152903.1756535-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Jun 2018 17:28:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8935 signatures=668703 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=660 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806260179 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, > The get_seconds() function suffers from a possible overflow in 2038 or > 2106, as well as jitter due to settimeofday or leap second updates, > and is deprecated. > > As we are interested in elapsed time only, using ktime_get_seconds() > to read the CLOCK_MONOTONIC timebase is ideal here. This also lets us > remove the hack that tries to deal with get_seconds() going slightly > backwards, which cannot happen with montonic timestamps. Applied to 4.19/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering