Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5443167imm; Tue, 26 Jun 2018 11:17:39 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKus4b5sH0PoxIgc2QthCsZLcVnFRnzI7pMBs4Ne+d9/z407qaQ6ZSupvK4lPdYlYU3SNzU X-Received: by 2002:a65:5641:: with SMTP id m1-v6mr2371813pgs.246.1530037059653; Tue, 26 Jun 2018 11:17:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530037059; cv=none; d=google.com; s=arc-20160816; b=eWjNaSKlmzLwJTHwW0MrPC00/clGC1RivFS/eCPTwO1S+b90SFWMDv4319R24Oloe/ 4Mm776X1B86y9HIb50v3akJEoIbvWy+obx1RhdutnPNxO6tTpnSzoatzTqiPYLb/47t1 wNd44koHHBl7RC7VEhcbxwde+2ieAgoxGZC4gMv+DWAaw19riY9ocPmTf788pjxxwgA9 FRs19zNDvSyTxgzciJwMhtl++SM2xl6SpfWpuY8hokmeY4hwfZaynAz0qt1tUC8iNRl9 PlngdrxM/JJXexwyGDbbGNYInpNVxmSREtFyCGYV1ZqlpMM+VDA+UHwBDGkw+G00BOjQ YetA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=lCC9U1Z5WId1JXdfwb2Ab1mtqBW4PoAZmUKRhbX89/Y=; b=QsYiDu2XlBII6gm0QEJTL6qWFwghj/wIUk8QXhJ/8t9kkOPYI4gUMiNtKhS2QHEMtm zqhkDF6jEwJy3uVBgP54FKfdPfJjId34T0c+sSkeMdyADJ7HH8VOtpHVLewj2MGzGgHL IrsLy7/kBqISEcV5CxckHpuxJUEicIqzuEcR+nNgA2mlvnpxE+DPpSbgf9FD6MUrQu+L IxlxjsEa+wmUG+RR0rLr2liBvIv048H9m81ybcPm3qcg2f7ZqofVOXLMng2ZOLSmNf1K 6KbPq8IjmSRymvdmG2dDhS+InhfJ+ZAYCL6H3YjtvzmNHBnp+mduoWuMdPJnpSGiGyjM dLGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3-v6si2181815pld.50.2018.06.26.11.17.25; Tue, 26 Jun 2018 11:17:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbeFZQFL (ORCPT + 99 others); Tue, 26 Jun 2018 12:05:11 -0400 Received: from mail.us.es ([193.147.175.20]:60938 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbeFZQFK (ORCPT ); Tue, 26 Jun 2018 12:05:10 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 33B7A1022AD for ; Tue, 26 Jun 2018 18:03:35 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 04E65DA792 for ; Tue, 26 Jun 2018 18:03:35 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E8E5FDA4CA; Tue, 26 Jun 2018 18:03:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id BF398DA794; Tue, 26 Jun 2018 18:03:32 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 26 Jun 2018 18:03:32 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (129.166.216.87.static.jazztel.es [87.216.166.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 840F94265A4E; Tue, 26 Jun 2018 18:03:32 +0200 (CEST) Date: Tue, 26 Jun 2018 18:05:05 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jann Horn Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] netfilter: nf_log: fix uninit read in nf_log_proc_dostring Message-ID: <20180626160505.cabcyt6yraw5jnjz@salvia> References: <20180620163345.212776-1-jannh@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180620163345.212776-1-jannh@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 20, 2018 at 06:33:45PM +0200, Jann Horn wrote: > When proc_dostring() is called with a non-zero offset in strict mode, it > doesn't just write to the ->data buffer, it also reads. Make sure it > doesn't read uninitialized data. Applied, thanks.