Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5445095imm; Tue, 26 Jun 2018 11:19:54 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJs7bPZMRWByXUH453B1g5LULWj2wBBkEmfz2AvynwGUDe7EflarcRcvj/8lp8DuA4Tglur X-Received: by 2002:a65:40ca:: with SMTP id u10-v6mr2302184pgp.2.1530037194448; Tue, 26 Jun 2018 11:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530037194; cv=none; d=google.com; s=arc-20160816; b=yReMtyLXrY0Lw29My74F8XxEUlYGYtw2TwV6/oa943466CrhZeGSwbMsqJOJ7AolRT eroaLAZfD79V5xSfNrREV/5WdLkUjHSrx25SolglvMMAtE+h8FIVCk+57SNbfl8/OLzT 9euK+VyTIHSqe2BMnJwbLEHgLNkg8vGpfKU73tsFXIbcBqHMaehQPEYeWSQRHwwXo6GR E44Rgy1K3t48Drg+nuc53sLwZ0LchPRj92ZqKTl7SNVkX7oqryiLwzRQc0HvkdfRU3I4 fC4UxJqZDTIDAe9lvw7j6dKHudlkHFw47XKUlLVrKg4R1sFNOdjAObx6YkTBpZFvVq0t neNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=uvGqp5iQIQA9QsMD0baByy3DEu9VNRHOj2eDzYDNBU8=; b=NC4z41D8/xowGC8L6UWr+JwBg9rRGkW5RcFjxnTreQ7wrKhjnQ2bvHsLJtdMc0ZaVU tsvFO5NplaHFrRxGINAUobUh3O/o5Fk/CUpy7SsPQUj5InN7+7puzR9t21PP7ye28Mxb +NGEEF2uebhz+lv2Bs36pykD9PFcGJAXGn5WLPurbMin/8DFvIo349Twszi67hiO+OXR S0YP5MyHS6uYe/DuL5BOzQgP05qnZa5RqCPcfaM6JO4y8Q8OOSW62Bp7bM7t9bPOiJWg q7GIHyjg5VzRnTrduiubifdxn2R6xW1rFsUH+MUcFZrkwomu7kPMeMhzmRMwLMp0i08t vVYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y2-v6si2079176plk.473.2018.06.26.11.19.40; Tue, 26 Jun 2018 11:19:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbeFZQXn (ORCPT + 99 others); Tue, 26 Jun 2018 12:23:43 -0400 Received: from mail02.iobjects.de ([188.40.134.68]:52002 "EHLO mail02.iobjects.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbeFZQXm (ORCPT ); Tue, 26 Jun 2018 12:23:42 -0400 Received: from tux.wizards.de (p3EE2F038.dip0.t-ipconnect.de [62.226.240.56]) by mail02.iobjects.de (Postfix) with ESMTPSA id 0CCE141603FA; Tue, 26 Jun 2018 18:23:41 +0200 (CEST) Received: from [192.168.100.223] (ragnarok.applied-asynchrony.com [192.168.100.223]) by tux.wizards.de (Postfix) with ESMTP id B49C5F01613; Tue, 26 Jun 2018 18:23:40 +0200 (CEST) Subject: Re: [PATCH BUGFIX RESEND 0/4] bfq: fix bugs breaking bandwidth guarantees occasionally To: Paolo Valente , Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name References: <20180625195537.7769-1-paolo.valente@linaro.org> From: =?UTF-8?Q?Holger_Hoffst=c3=a4tte?= Organization: Applied Asynchrony, Inc. Message-ID: <371643da-7465-91d8-6765-65905776be64@applied-asynchrony.com> Date: Tue, 26 Jun 2018 18:23:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180625195537.7769-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/25/18 21:55, Paolo Valente wrote: > Hi, > during some bandwidth tests, I found some occasional but severe > malfunctions (losses of bandwidth control). The first three patches in > this series fix the bugs that caused these malfunctions. The last > patch is a fix/improvement of the name of one of the functions > involved with these bugs. > > I guess these patches are appropriate for next kernel release. Ran these overnight on 2 machines on top of recent BFQ and nothing caught on fire. One funny benchmark result stood out since it gave me (repeatedly!) 560 MB/s read bandwidth on an SSD which is rated to do "up to 550MB/s", so I guess BFQ's bandwidth guarantees are now really quite strong. :-) Therefore: Tested-by: Holger Hoffstätte cheers, Holger