Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5497855imm; Tue, 26 Jun 2018 12:19:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIYj1Oq849qdVcsprxarj/8zi/VPtsvbPV1T4WlZ+61f5bzNxpDO+OH60XRV3vFGi8YmaKZ X-Received: by 2002:a17:902:1023:: with SMTP id b32-v6mr2956264pla.145.1530040759679; Tue, 26 Jun 2018 12:19:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530040759; cv=none; d=google.com; s=arc-20160816; b=kwfLLPvDGLlj7aTVrWTTL8tGG5Gata+vbwlwb85XT4r6gTtqIwvcuLr/fD0o9nUG7M PVEbiBGR8esWnpQ5MyWQfhxefY/y+bfgdJCGbymoL1WiYlxLlDfb92hImM7mhmGExnEU VN3odDHzdc+4mKul61+iErjNdabI7OjhbJ8XLR4PzQOz/nAgepcAWR7ENq5dm21oHfpS JiFehAFvSTrlqqNqOd0Kk9LeejCNFuIdr8YL8EFVHxPA28sk3+ZF2Ci5lu1QHhTjCev3 ksawKpeVenfr+Qa+bmMcbXsuGg2kkUiqNdyQ9kWweu7VPdu5n1vjHHv8RsjLr6sozNqG 1v4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Dp4Gsuyo/S0fzQlMRo3ONbiMgTgD1AULKi8sXQ1s+cU=; b=qjTKVEPGrhQXbOOY/P6uTbN6U6PPO5fSHObyFO/pzbQ6pAI36H1KU+kAb4SZbTv5o/ 7POjixJ+bNpyYeSmzZaxcSIXVvbgBGYEhBBTZ30D3sg3yz337i9XfxqLNAeSbQThwpKb 4SOoSP/53l4ygw1Vv+37DD/EcBpqLjZhZfJrvqyNIA2uPIGKSzKYlIjELrhU8QZ9mJ1k rnjrMRRmudy205y41akJhjivD2x+B7zTZg3kgVwawum8MZfe6Ig3U4M58ufTHNaZfSsa YDi/Sjiv9BXNAJ84l5tmJQ7ma5+AnA36h5ONLA4aeY6MKf5zLJmXto9BR8BUcqXHvPHi a7vA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=XTy+JyS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17-v6si1907504pgf.352.2018.06.26.12.19.05; Tue, 26 Jun 2018 12:19:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=XTy+JyS3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933898AbeFZSww (ORCPT + 99 others); Tue, 26 Jun 2018 14:52:52 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:46347 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933266AbeFZSwu (ORCPT ); Tue, 26 Jun 2018 14:52:50 -0400 Received: by mail-oi0-f66.google.com with SMTP id h79-v6so16975690oig.13 for ; Tue, 26 Jun 2018 11:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Dp4Gsuyo/S0fzQlMRo3ONbiMgTgD1AULKi8sXQ1s+cU=; b=XTy+JyS3Gksn6bTQ8jSHKPA8uIkXPlQvUOSbLwCEudZzsW3Q5EDTKKg6bjOvjkmMsw LwLJnDVRlz/qryEeuUxjdTxGk9u6COC4oW+7ToCzZ4iNKYYg+WKSEz1RlP64D1ldOmBp OkTC9/VJ/32KK97Tg1IEJA6bcR61EuCJHfRCnlqtt0Yh/2fgPby0Gqz9BXYd8a7HZ5MM Q8Zw2TmQkq2Pz5dLsGFh1rBSQbUvPiDVm9kmIIWTSUmvKk3uA70HS5NOOSX6PwqIcaBz AyeUMD0NSz3kOgZIuZVOn/VoRoM0539VrpEY46Ryy5pbnn1Lnvf27CriG1+mgMv280YR EX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Dp4Gsuyo/S0fzQlMRo3ONbiMgTgD1AULKi8sXQ1s+cU=; b=iX922+mp3cvkNqXzopcSb78/vqTvS9Bk2566+dQFz2XNand/phOuYyGWI73D+hBANU ahyXuGgskx8UpC/FLDuMWvIkzimu6SDpgCbIRRbQUXL0ZP0XYfdY5fgw6WoUvZmZPV5T sqA6U31HyEi1MqsW5Umk16hLJLp0g8jp+AJe9agDEG9V7AiLcTp573ApIHluaqhRhI5+ 3jDObQcPNQGpODJu9DHpjnOD3MojOoiLQLujJtIASbuOLzL/yF+2FEM8LKhaFMKyeTKv t94bfpWaDfqr+ntha0BWnRD/qtKl8fC2cRcdSdq1/Rv1Vb61W3Z8gsSlAvUxJLIuLvra W/HQ== X-Gm-Message-State: APt69E0KCxLaCC5o7Mt1SsvJlCYAwvEFnRxoVDTeNOmFKOP/bGuZYG/J ZLyl04N3YF8cNWbNOuzKUfFEc4K1JaBqedweMEwVlA== X-Received: by 2002:aca:745:: with SMTP id 66-v6mr1431536oih.295.1530039169643; Tue, 26 Jun 2018 11:52:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:38c2:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 11:52:49 -0700 (PDT) In-Reply-To: <20180626175932.8899-2-ross.zwisler@linux.intel.com> References: <20180626175932.8899-1-ross.zwisler@linux.intel.com> <20180626175932.8899-2-ross.zwisler@linux.intel.com> From: Dan Williams Date: Tue, 26 Jun 2018 11:52:49 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] pmem: only set QUEUE_FLAG_DAX for fsdax mode To: Ross Zwisler Cc: Toshi Kani , Mike Snitzer , device-mapper development , linux-nvdimm , Linux Kernel Mailing List , stable , linux-xfs , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 10:59 AM, Ross Zwisler wrote: > QUEUE_FLAG_DAX is an indication that a given block device supports > filesystem DAX and should not be set for PMEM namespaces which are in "raw" > or "sector" modes. These namespaces lack struct page and are prevented > from participating in filesystem DAX. > > Signed-off-by: Ross Zwisler > Suggested-by: Mike Snitzer > Cc: stable@vger.kernel.org Why is this cc: stable? What is the user visible impact of this change especially given the requirement to validate QUEUE_FLAG_DAX with bdev_dax_supported()? Patch looks good, but it's just a cosmetic fixup afaics.