Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5515937imm; Tue, 26 Jun 2018 12:40:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL840o7LWD1s7PNLAkpjNcVq7WiBSb8pOtMGT8U3L7nptUaxjDBNIB6dAq9ZJLC8U33xnuX X-Received: by 2002:a63:ae43:: with SMTP id e3-v6mr2421294pgp.181.1530042056424; Tue, 26 Jun 2018 12:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530042056; cv=none; d=google.com; s=arc-20160816; b=xQHAREdi75neXaCt0E9hDev3L7lGapskf5IKrNFiUppVP4rfpIHxtIbAFruJnCwPeR huUJxcVT9F3UwnpUbhsEyw/jumwvvR8A/DM6JVejxAWiEgMjWQKYz/ffgcpuMgHlVVai Ow2fzLW5KOjQUv+gLygs5pNmLz00vXqwmGOw+q+StDi1xD9EhrEaHicY/k0HHmd57rJv lkigCJxwkEBWC4/DjbmdxaABtNxvoaHRpjwCPVxNVGj+uCHwaBa3SxhZs3HQRBB+hsaz 3RTo/mGe7XOr07TEbx859JwNjuXArASUBB7oNB/o8eZJsxes+UxB+oXl+g0fgr/ZVEKr 6ZJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=3NLBw74Tb7e9Icka9Y0s7C/SNJsVScBTC5dPAQCa0Ck=; b=GfNtp38KyM8Ak1iZ1yEz3rzAkQ9R+rW87WHPa/A25yqOv+WcwI0f1QKOG+5ESRhoQP KBWpeRN7p/jWor2ENeJ+co2PoWBQIf2JcRvrcm+A6hfjxKseEhRGcLgnQ6Jqyq7RizKZ mhTBGVrUuibM2of0Rp+ZXHZ/3utLxJIpzxSmrp/NU6FyHTyMc2Vdu93gRpG4eFHRXlUg J9H16PpkLsNZM0xClJvCJYH9fMarsqLheup2X4JvA+bCN4VE9xJ6wKtmbnFrOZz3m2RW fFsxwD3C3vi7uK+ZCe3tU+pFRdM1E1ul/WsHprMX34IyaUTzgSOyKgFqOxtsPNlWHa80 DRyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0FKi9V+6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v73-v6si2237551pfi.22.2018.06.26.12.40.41; Tue, 26 Jun 2018 12:40:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=0FKi9V+6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754769AbeFZTiN (ORCPT + 99 others); Tue, 26 Jun 2018 15:38:13 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43728 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752147AbeFZTiL (ORCPT ); Tue, 26 Jun 2018 15:38:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=3NLBw74Tb7e9Icka9Y0s7C/SNJsVScBTC5dPAQCa0Ck=; b=0FKi9V+6j7tJhgfaZI/JWYKu5Nlue3kXND7mLpxUvR9YpMRmE1Uxcq4+lINEah4qETXIzGsoTM8sVJvpw8lF3rnLhkm7f4f+atYr9cC3T4jFOLPKXn7Nidpgak1UiWc3t98ceot49DMFgbWvDSTuInQ5JQOQg/wTm4OJbITJmJ8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fXtmx-0004Kr-Ef; Tue, 26 Jun 2018 21:38:07 +0200 Date: Tue, 26 Jun 2018 21:38:07 +0200 From: Andrew Lunn To: Brandon Maier Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com, kristopher.cory@rockwellcollins.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 3/3] net: phy: xgmiitorgmii: Check read_status results Message-ID: <20180626193807.GE9800@lunn.ch> References: <20180626175050.71165-1-brandon.maier@rockwellcollins.com> <20180626175050.71165-3-brandon.maier@rockwellcollins.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180626175050.71165-3-brandon.maier@rockwellcollins.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 12:50:50PM -0500, Brandon Maier wrote: > We're ignoring the result of the attached phy device's read_status(). > Return it so we can detect errors. > > Signed-off-by: Brandon Maier Reviewed-by: Andrew Lunn Andrew