Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp5698928imm; Tue, 26 Jun 2018 16:27:41 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJk1k/NVPiLyQpAkt3jOEYMrN56N1LxtUaxVP3N0VGL8i7niWLGuapTgnc3XXFMZfK09WBa X-Received: by 2002:a65:5304:: with SMTP id m4-v6mr3043317pgq.250.1530055661067; Tue, 26 Jun 2018 16:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530055661; cv=none; d=google.com; s=arc-20160816; b=gOEFfSpbmkg5UpKd1/CNIMBZlxDOLlSSkogRpH0gdtZTciw1tzp8/veVOB3gqsvh5A ZEgouE5SvBmW8Gqh1X91sQK3Neai/8n34VREqCXuAl7e/qDO7lDFLlgo9SfVmflkO7f4 SRmPj55QNrehLtJvmOIR0L0awUVMGedtzLCVPQNH22iylfAK/MYuxo8vt+2iZi//nu5L Q7dQJvXW8qCxTueuRGi2UyaKlVU68tPGefnHrYbySRBo++wrEUtrPeJRbsY3QqL0cpD6 N86gwAwy2XcqMpcWx+zLItVy6CYMi1JKVZI62P5a/on8uu7WxkEmWWd2p9mOvFPiUr0T N9WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:subject:cc:to :from:date:arc-authentication-results; bh=jMChiLTfZhrGeKj/fR75bxa5+cxhPAxgIfRSFs139w8=; b=HF6QU0+NEMUkJxxvZVylw6DAJv/xKDkNv3Oko/mZuPbiZ8ZnY24BcS5gZgFeIoycfb 8xFCodr1EjOMdqasyXvFMgLXbOpfZxzQnwrk1Ucd/gWMG/6+Gta8tpUN630zUNpgfLV/ lIaBgUGQcVlLft1Vy+uFC1u4gi5KQqNXNu8pTlM8OkmGQNHlJgv1OJVlG2GTOFmW1y0/ +JGKxmFTBg4u4jncq5si1kyEV0iw4RB4yswBFL5nO+3e/Y2dxplwhZx91Jm0/8+uj6to x0K/FVtYdZT7CNj40U2rS1oUFzLqIX40UTiCdcGjU+pooa1n7HTjkNvQTFQHA6alWJ6a xxNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y123-v6si2297512pfc.302.2018.06.26.16.26.56; Tue, 26 Jun 2018 16:27:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbeFZSG5 (ORCPT + 99 others); Tue, 26 Jun 2018 14:06:57 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36904 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751953AbeFZSG4 (ORCPT ); Tue, 26 Jun 2018 14:06:56 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w5QHsnxZ001416 for ; Tue, 26 Jun 2018 14:06:55 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2juq8b8n87-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 Jun 2018 14:06:55 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 26 Jun 2018 14:06:54 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 26 Jun 2018 14:06:51 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w5QI6oDg5112280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Jun 2018 18:06:50 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D9DBAB2067; Tue, 26 Jun 2018 14:06:43 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B4550B2064; Tue, 26 Jun 2018 14:06:43 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.70.82.159]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 26 Jun 2018 14:06:43 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id AB08316C15BE; Tue, 26 Jun 2018 11:08:55 -0700 (PDT) Date: Tue, 26 Jun 2018 11:08:55 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org Subject: Re: [PATCH tip/core/rcu 16/27] rcu: Add comment documenting how rcu_seq_snap works Reply-To: paulmck@linux.vnet.ibm.com References: <20180626003448.GA26209@linux.vnet.ibm.com> <20180626003513.27812-16-paulmck@linux.vnet.ibm.com> <20180626171454.GI2494@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180626171454.GI2494@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18062618-0068-0000-0000-0000030E8709 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009259; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01052687; UDB=6.00539680; IPR=6.00830612; MB=3.00021865; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-26 18:06:54 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18062618-0069-0000-0000-000044D14EC5 Message-Id: <20180626180855.GE3593@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-26_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806260202 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 07:14:54PM +0200, Peter Zijlstra wrote: > On Mon, Jun 25, 2018 at 05:35:02PM -0700, Paul E. McKenney wrote: > > From: "Joel Fernandes (Google)" > > > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > Since you had me looking at them functions; why isn't rcu_seq_snap() > using smp_load_acquire() and rcu_seq_end() using smp_store_release() ? > Their respective comments seem to suggest that would be sufficent. I do not believe that this would suffice. Would it make sense to refer to Documentation/RCU/Design/Memory-Ordering in the comment header? Except that this would invite sprinkling this pathname far and wide... The key point is that these functions are part of the any-to-any memory-ordering guarantee that RCU grace periods provide. Thanx, Paul