Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265852AbTIJVvw (ORCPT ); Wed, 10 Sep 2003 17:51:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265853AbTIJVvw (ORCPT ); Wed, 10 Sep 2003 17:51:52 -0400 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.202.12]:10944 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id S265852AbTIJVvt (ORCPT ); Wed, 10 Sep 2003 17:51:49 -0400 Date: Wed, 10 Sep 2003 23:51:37 +0200 From: Adrian Bunk To: Tom Rini Cc: Eyal Lebedinsky , Kernel Mailing List , pavel@suse.cz Subject: Re: [patch] 2.6.0-test5: serio config broken? Message-ID: <20030910215136.GP27368@fs.tum.de> References: <3F5DBC1F.8DF1F07A@eyal.emu.id.au> <20030910110225.GC27368@fs.tum.de> <20030910155542.GD4559@ip68-0-152-218.tc.ph.cox.net> <20030910170610.GH27368@fs.tum.de> <20030910185902.GE4559@ip68-0-152-218.tc.ph.cox.net> <20030910191038.GK27368@fs.tum.de> <20030910193158.GF4559@ip68-0-152-218.tc.ph.cox.net> <20030910195544.GL27368@fs.tum.de> <20030910210443.GG4559@ip68-0-152-218.tc.ph.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030910210443.GG4559@ip68-0-152-218.tc.ph.cox.net> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2630 Lines: 71 On Wed, Sep 10, 2003 at 02:04:43PM -0700, Tom Rini wrote: > On Wed, Sep 10, 2003 at 09:55:44PM +0200, Adrian Bunk wrote: > > On Wed, Sep 10, 2003 at 12:31:58PM -0700, Tom Rini wrote: > > >... > > > ===== drivers/input/keyboard/Kconfig 1.6 vs edited ===== > > > --- 1.6/drivers/input/keyboard/Kconfig Wed Jul 16 10:39:32 2003 > > > +++ edited/drivers/input/keyboard/Kconfig Fri Sep 5 14:45:36 2003 > > > @@ -2,8 +2,9 @@ > > > # Input core configuration > > > # > > > config INPUT_KEYBOARD > > > - bool "Keyboards" if EMBEDDED || !X86 > > > + bool "Keyboards" > > > default y > > > + select KEYBOARD_ATKBD if STANDARD && X86 > > > depends on INPUT > > > help > > > Say Y here, and a list of supported keyboards will be displayed. > > > @@ -12,7 +13,7 @@ > > > If unsure, say Y. > > > > > > config KEYBOARD_ATKBD > > > - tristate "AT keyboard support" if EMBEDDED || !X86 > > > + tristate "AT keyboard support" > > > default y > > > depends on INPUT && INPUT_KEYBOARD && SERIO > > > help > > > ===== drivers/input/serio/Kconfig 1.9 vs edited ===== > > > --- 1.9/drivers/input/serio/Kconfig Wed Jul 16 10:39:32 2003 > > > +++ edited/drivers/input/serio/Kconfig Fri Sep 5 14:45:36 2003 > > > @@ -2,7 +2,8 @@ > > > # Input core configuration > > > # > > > config SERIO > > > - tristate "Serial i/o support (needed for keyboard and mouse)" > > > + tristate "Serial i/o support (needed for keyboard and mouse)" if !(STANDARD && X86) > > > + select SERIO_I8042 if STANDARD && X86 > > > default y > > > ---help--- > > > Say Yes here if you have any input device that uses serial I/O to > > > > This works but seems fragile since everyone touching the dependencies > > must know that the tristate dependencies of SERIO must always match the > > select dependencies in INPUT_KEYBOARD. > > How so? SERIO only selects SERIO_* bits, and INPUT only selects INPUT* > (and, imho, keyboard is input :)) bits. >... Let's say you remove the X86 dependency in the select in INPUT_KEYBOARD. If you select SERIO=m on !X86 (with EMBEDDED/STANDARD enabled) this will select KEYBOARD_ATKBD=y... > Tom Rini cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/