Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6150763imm; Wed, 27 Jun 2018 03:07:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcEgHcWKRCWnq4MPVDiIou577M++s12SaHKmBuiA3ymXDc3gnu22T+4OkKCZSW3Qx6ua1Zw X-Received: by 2002:a62:c296:: with SMTP id w22-v6mr5240788pfk.92.1530094075614; Wed, 27 Jun 2018 03:07:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530094075; cv=none; d=google.com; s=arc-20160816; b=TTeBpQvMxywDp/DiVnHrdyf0n4oMs9CFIqs0IrDcViW0P37JfYKDTG6/zI+k8VhSnV IPqvUQ+myp7hYhpvXMkt5iqAGd9cz8jKU0afrqtiqSeOrAOAjk6x7AsbWS04rZvtYU6F MOPPpeb916Srdo4dCHwhjAn714ZK2SB3ghaoFk4Rrq3dty7Xy45ikRdvMYAk4bFcec6D js6JeCbGIEmXlzGpCqreP4r524BIqcP5kC4DBi+BMxFl7mAMykYArDpOv/S+wC2Rt7IU ekqlRGL52WEKZ9veDpC/Qt+z6OVpy9jfKprO381e2h09V4qR9oUA+t9enqY+cf97Lu/v ek0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=h98LIIgiafbl1TS/Q37nq2FOfXq8DxhRk1/9aa0a8CM=; b=poYqIJj37fyUBfK+3fr1eHzFAupQXKKhoq95JqNNiM30bWwzEkB5PUSeFwHWYIvpYQ ZI/IzFRA1YmAp5rvPnyWkIIxqEX7j8P5bqUsIstf2dcyn9oSlGy5DJohjVL2skDbbzgP uqxqQiM2+qPDtCZC0vN2ze0idKlKT9S+6X623rNju7PkPPH61mk2gvFTb6mj+mHXxKtr jtnPUH3yCBIhOWxMFZMbyeyGPQploiDoewPqcQKVTS5Dk2avzQ3N1lvIW+EnRrQKaFln PpBcsDR6zvbZcj/qGKouPhwxWIgn2YGyBSsvJ9FGMi5gNSLyp3IZGnuquuh+e5h14XIn c4YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u189-v6si3961901pfu.143.2018.06.27.03.07.38; Wed, 27 Jun 2018 03:07:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbeF0JkW (ORCPT + 99 others); Wed, 27 Jun 2018 05:40:22 -0400 Received: from mga06.intel.com ([134.134.136.31]:27152 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbeF0JkU (ORCPT ); Wed, 27 Jun 2018 05:40:20 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 02:40:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,278,1526367600"; d="scan'208";a="66719739" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004.fm.intel.com with ESMTP; 27 Jun 2018 02:40:14 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id B3570205FC; Wed, 27 Jun 2018 12:40:13 +0300 (EEST) Date: Wed, 27 Jun 2018 12:40:13 +0300 From: Sakari Ailus To: Bartosz Golaszewski Cc: alanx.chiang@intel.com, linux-i2c , andy.yeh@intel.com, Andy Shevchenko , andriy.shevchenko@intel.com, Rajmohan Mani , Andy Shevchenko , tfiga@chromium.org, jcliang@chromium.org, Rob Herring , Mark Rutland , Arnd Bergmann , Greg Kroah-Hartman , Linux Kernel Mailing List , devicetree Subject: Re: [PATCH v3 1/2] dt-bindings: at24: Add address-width property Message-ID: <20180627094013.e42crqqufo2jqra6@paasikivi.fi.intel.com> References: <1530078385-1546-1-git-send-email-alanx.chiang@intel.com> <1530078385-1546-2-git-send-email-alanx.chiang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2018 at 10:19:38AM +0200, Bartosz Golaszewski wrote: > 2018-06-27 7:46 GMT+02:00 : > > From: Alan Chiang > > > > The AT24 series chips use 8-bit address by default. If some > > chips would like to support more than 8 bits, the at24 driver > > should be added the compatible field for specfic chips. > > > > Provide a flexible way to determine the addressing bits through > > address-width in this patch. > > > > Signed-off-by: Alan Chiang > > Signed-off-by: Andy Yeh > > > > --- > > since v1: > > -- Remove the address-width field in the example. > > since v2: > > -- Remove redundant space. > > > > --- > > Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt > > index 61d833a..aededdb 100644 > > --- a/Documentation/devicetree/bindings/eeprom/at24.txt > > +++ b/Documentation/devicetree/bindings/eeprom/at24.txt > > @@ -72,6 +72,8 @@ Optional properties: > > > > - wp-gpios: GPIO to which the write-protect pin of the chip is connected. > > > > + - address-width: number of address bits (one of 8, 16). > > + > > Example: > > > > eeprom@52 { > > -- > > 2.7.4 > > > > Rob, > > we only have two possibilities here and the default is 8 bits. > > What do you think about introducing a boolean property here called: > 'address-width-16' instead of an integer? I'd have thought the same, but it turns out address-width is already being used by the at25 bindings: Documentation/devicetree/bindings/eeprom/at25.txt -- Sakari Ailus sakari.ailus@linux.intel.com