Date: Wed, 10 Sep 2003 15:36:01 -0700
From: Andrew Morton <akpm@osdl.org>
To: jbarnes@sgi.com (Jesse Barnes)
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] you have how many nodes??
Message-Id: <20030910153601.36219ed8.akpm@osdl.org>
In-Reply-To: <20030910223430.GA18244@sgi.com>
References: <20030910213602.GC17266@sgi.com>
	<20030910151254.52f53e62.akpm@osdl.org>
	<20030910223430.GA18244@sgi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1182
Lines: 34

jbarnes@sgi.com (Jesse Barnes) wrote:
>
> On Wed, Sep 10, 2003 at 03:12:54PM -0700, Andrew Morton wrote:
> > I think.  We could just say "dang numaq needs five bits", so:
> > 
> > 
> > 	#if BITS_PER_LONG == 32
> > 	#define ZONE_SHIFT 5
> > 	#else
> > 	#define ZONE_SHIFT 10
> > 	#endif
> 
> That's fine with me, do you want me to rediff and send a new patch?
> 

Well your patch as it stands would appear to break NUMAQ builds, due to
NUMAQ setting MAX_NUMNODES directly in the arch code.  ia64 is using
another layer of macroification via NR_NODES instead.

MAX_NUMNODES, NR_NODES and MAX_NR_NODES appear to be a bit of a mess, and
they should all be replaced with shift distances anyway.

Could you please get together with Martin Bligh, come up with something
which works on NUMAQ and your 128 CPU PDA and also cast an eye across the
other architectures (sparc64, sh, ...)?  It all needs a bit of thought and
a spring clean.

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/