Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6431080imm; Wed, 27 Jun 2018 07:36:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI/+5trQCMQRDWIHvoTa54rxPAUkZ0LoyB9g0t1Bh2xlxvJbsKdXQqbteVUU3lxXFSf0Z4p X-Received: by 2002:a17:902:9a95:: with SMTP id w21-v6mr6438376plp.168.1530110208157; Wed, 27 Jun 2018 07:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530110208; cv=none; d=google.com; s=arc-20160816; b=QkJYmMpzIJ0lR1bN2+iTzTs/W9+Rx6nFwF1XiCeLjc8vXd4RQSg7fCO4jIvCv5HX7v /D/XncZuqtulS0stPcFgkg+Nv/sk7Tj/oB9xAo35qMpSsqBZY5xzrWb/BOJbj/WJUe1o HnopPCV+9rbhmrlkGdZUsaC1+baWOt2akLukXiGEgKY9yvf12hAQQaLCWXJuXMhh1bkF N++oezYYGTh7BUY3+q/14FxlWuBVbTfzmMNt3sb0x6WHflnPx18RNtOsCdAc9sRBWnv0 T/D6qAJ6vjBQedZgQ+uJj7vjZvrlIH3Vb9C41ckRClE6ZqJvWJXIal2RPwnv5+I6UyLB MjLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=Sek4nJClBlZE03PAQdeNqa7C5dZXNIFKwzOMqnolDKg=; b=wuChqEoq5gWglEPR+eYd51LMX1CM1j5Q26VF3QUXz+qk6mHceIlEqBYoxdGri6mCI4 A0HKprTcLAlEmkIWB5Z8EYFEeqx2Xj4YS6gE1rlsgmY2mdK1828YSthStssmZGUiEg1w ca5xqOt7uJK2miVcxEj8d/ZROAAOlrn4M3BsHZBlYPQVlXI6Ph1Bb4NSU+EYzO7mNl5T J6i9/80n07ZWdy0qxptY7DMLa58oIRh5Dgq2RF5zLO3xsxRm1ll22W5SOE4l/4F35uqN O+KIe2Yxur5luRpSM9dhh/rKfrw1fomPnZUsyeEdhj0/TrqPSvDTOSilHHbppLfKMeyI lx+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25-v6si3926827pfh.101.2018.06.27.07.36.33; Wed, 27 Jun 2018 07:36:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934614AbeF0OfU (ORCPT + 99 others); Wed, 27 Jun 2018 10:35:20 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:49450 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932907AbeF0OfS (ORCPT ); Wed, 27 Jun 2018 10:35:18 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fYBXE-0000A5-C3; Wed, 27 Jun 2018 22:35:04 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fYBX3-0003cw-KX; Wed, 27 Jun 2018 22:34:53 +0800 Date: Wed, 27 Jun 2018 22:34:53 +0800 From: Herbert Xu To: Kees Cook Cc: Eric Biggers , Giovanni Cabiddu , Arnd Bergmann , Eric Biggers , Mike Snitzer , "Gustavo A. R. Silva" , qat-linux@intel.com, LKML , dm-devel@redhat.com, linux-crypto , Lars Persson , Tim Chen , "David S. Miller" , Alasdair Kergon , Rabin Vincent Subject: Re: [dm-devel] [PATCH v2 10/11] crypto: ahash: Remove VLA usage for AHASH_REQUEST_ON_STACK Message-ID: <20180627143453.gu44ghqh6jnaf4tz@gondor.apana.org.au> References: <20180625211026.15819-1-keescook@chromium.org> <20180625211026.15819-11-keescook@chromium.org> <20180625225609.GA181665@gmail.com> <20180626091958.zy3m24sjukfbn7av@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 10:02:31AM -0700, Kees Cook wrote: > > There is no SHASH_MAX_REQSIZE? > > As for users of AHASH_REQUEST_ON_STACK, I see: These users are only using the top-level ahash interface. The underlying algorithms must all be shas. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt