Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6492369imm; Wed, 27 Jun 2018 08:29:46 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdfwoeSLDhRkyllh2rK/rEr1bhk5MG4jbqn3kVowJp/RuVBkBdxf0/uxSx0fvePjT87re5B X-Received: by 2002:a65:4a49:: with SMTP id a9-v6mr3852894pgu.267.1530113386502; Wed, 27 Jun 2018 08:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530113386; cv=none; d=google.com; s=arc-20160816; b=b38J9bQuSKz5ys1FPUZDNJ4hApYPy2No5SNySW4pFi5eEHgijFIpS8RIgc2fPgHgDk TklktX8WV8S+JMduT6d6kQFR4fBizhD9x6JlzcT4KHCEy9A3RrmLPxmFT0GJUs2NZ1RV WljNPrdkbK9lkZX9X08hT7lEO1IOXZu9qMpFwhrNw216hn2fAfVQpvYdfojHSc8GpoOG rhFO24L0LdIoWUUqBSr6Dsqxjto+p5uGmgfWcJTKJKAZ0rjR7JMT9+J7akANzITA/79B NLKnyyCzEWQWvrHhUIANa9SUW/qnTRaBO3vV7IM/Y2lcFGNTlkPig6knyPU1eitZdNlv wA+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=sIfRx432+dn+nBytQlqPgA8VECdYeCgneEHZNax9ryo=; b=fYyZqH3yhaG4bN5MbKjwM7VDEUWtn7TjM+6V7gGQa942fni7eJSCO2ro+jbzQD3QjY QTCFGX4zPP/GrMGDHLqIyHOO3VQKwUpzr47ljDxLPE4ilmyeVTx4dbWjKHNSxHA/V2+y QCRHDBvCSJ016uE7z1X1Ah2NDx7rxKk0avkVegFR5upQnRJTG1bTyLmVXmG/U1I3rNLl 7aa1rZb0A5HxO1P2AHa1LMNElMRJqXoxg1XD/pvTmbymhwmNZGrdG9OtwkNet/etzpoB EBkbX9uLt2MibBXU7NUOdXTLPo+xNQet5MzV7Q2lG/Kc+V7YOH5ae7MpXHP2qrCNdqMR WkMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c0aJzp1F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b1-v6si3746573pgb.465.2018.06.27.08.29.32; Wed, 27 Jun 2018 08:29:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c0aJzp1F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbeF0P10 (ORCPT + 99 others); Wed, 27 Jun 2018 11:27:26 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:37578 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbeF0P1Z (ORCPT ); Wed, 27 Jun 2018 11:27:25 -0400 Received: by mail-pf0-f175.google.com with SMTP id y5-v6so1132800pfn.4; Wed, 27 Jun 2018 08:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sIfRx432+dn+nBytQlqPgA8VECdYeCgneEHZNax9ryo=; b=c0aJzp1FPvMzY0ikI7dNByX5lQtXXjOjG5VnZQLQTTb6O/5AdXXnORcGInKsW+BZsM 70nbi/Pu3okg0GIUfYA18VYu9IBPuAZxjiao01wnGzAKvJ7umi62mLOcD+QzgSFFCUdQ LcfFtyAzOZJ7rCDf8xJqnlRb38Q5QfoEsvzJEri/kgY8CX8Gn4xObV5PP/qSt2KiNutK Alt9pNOKdjhJKYHL94GDuMzRS98xSe8p+xX8z7XKy/rQ35neTbYq5nrvmpN3NYQa+dcb XRJOPtY4dDcuaXIwUIUHH/qvQYiUb8aWxmFh2Eo5YOpvFL4y7vsyXQUfRpSNiZgiERcM sWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sIfRx432+dn+nBytQlqPgA8VECdYeCgneEHZNax9ryo=; b=oC/8N4/UsZWysNzpVTMVyPvA1RFsjtGcppjuz5ZamcPMJE4i/p7ROlg6T6xVSBA1M+ v9p7K9uhOpSnfrB5gyaFg6ehfQjSQx29IdqDQvnrHfvSY7U7HxSZQW+G9xbS/oCIN+eU ZP6uBAvgRrucLlkeznaNj0gCQBCOyqrTwZhgnzX39aDnVwNObIPZhlRMOAfT3hRjXMDc qWqErmcPNBtS3JAssSWIFN37LuRFJ8nORv4SGEDZ1yAryB1uadg/YIBx10VJyIv16RV1 BJ5i4TZzHKYGbvDSWSDqiDYdg/2hcOOGzAODBNk4kY9dnXJpV2j8fFF1cxJ8l0YiMweI mIcg== X-Gm-Message-State: APt69E03hqw5M4IFD/s2eObSn+vqf8+WVLcZonD5tTbw88PEvv+TgNF7 QmSPc8jHF51VCD7LmcqN5hVK1NV6 X-Received: by 2002:a62:9419:: with SMTP id m25-v6mr6325592pfe.120.1530113244301; Wed, 27 Jun 2018 08:27:24 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id s14-v6sm6656161pfh.116.2018.06.27.08.27.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 08:27:23 -0700 (PDT) Subject: Re: [PATCH net-next] tcp: replace LINUX_MIB_TCPOFODROP with LINUX_MIB_TCPRMEMFULLDROP for drops due to receive buffer full To: Yafang Shao Cc: Eric Dumazet , David Miller , netdev , LKML References: <1530100216-13070-1-git-send-email-laoar.shao@gmail.com> From: Eric Dumazet Message-ID: <72f02552-9375-bf81-6a03-42656168b583@gmail.com> Date: Wed, 27 Jun 2018 08:27:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/27/2018 08:14 AM, Yafang Shao wrote: > Got it! > > What about introduce a new counter, i.e. TCPRcvQFullDrop ? tcp_try_rmem_schedule() can fail for many different reasons, not related to how occupied the socket receive queue is.