Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 27 Jun 2018 16:48:04 +0100
From:   John Whitmore <arigead@gmail.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Justin Skists <justin.skists@juzza.co.uk>,
        devel@driverdev.osuosl.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        John Whitmore <johnfwhitmore@gmail.com>
Subject: Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize
 memory, instead of loop.
Message-ID: <20180627154802.vnkyhl3yqfptzeq7@xux707-tw>
References: <20180624153454.27356-1-johnfwhitmore@gmail.com>
 <20180624153454.27356-4-johnfwhitmore@gmail.com>
 <CAHp75VegybTJJ8GruGORxB3NChgsEKN+kJF55UjU0OvP2svuQQ@mail.gmail.com>
 <20180625123559.pvjrpmbtk6z24uew@xux707-tw>
 <848175111.798938.1529931904819@email.1and1.co.uk>
 <20180625195025.xfbrlj7citq3qx6s@xux707-tw>
 <20180626035640.GA29538@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180626035640.GA29538@kroah.com>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 26, 2018 at 11:56:40AM +0800, Greg Kroah-Hartman wrote:
> On Mon, Jun 25, 2018 at 08:50:26PM +0100, John Whitmore wrote:
> > On Mon, Jun 25, 2018 at 02:05:04PM +0100, Justin Skists wrote:
> > > 
> > > > On 25 June 2018 at 13:36 John Whitmore <arigead@gmail.com> wrote:
> > > > 
> > > > 
> > > > On Mon, Jun 25, 2018 at 12:06:30PM +0300, Andy Shevchenko wrote:
> > > > > On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore <johnfwhitmore@gmail.com> wrote:
> > > > > > Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
> > > > > >
> > > > > 
> > > > > Suggested-by ?
> > > > >
> > > > 
> > > > Em, not sure how to respond, it certainly wasn't my idea. I was just making
> > > > coding style changes, badly. ;)
> > > 
> > > Suggested-by is a tag for patches, to give credit. For example:
> > > 
> > > https://elixir.bootlin.com/linux/v4.18-rc1/source/Documentation/process/submitting-patches.rst
> > > 
> > > See section "13) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:"
> > > 
> > > Hope that helps,
> > > Justin.
> > 
> > Oops... that helps thank you. I have to re-read that document, it obvioiusly
> > didn't all sink in :(
> 
> I've dropped this patch, can you fix it up and resend?
> 
> thanks,
> 
> greg k-h

Yes I'll resend this patch, sorry about that error

jwhitmore