Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6517845imm; Wed, 27 Jun 2018 08:52:26 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeQ7ERY3XehdUWTWe+rGzPw/2iDlJFGFuWcWXjYV4ymk2zgp8a6B9G1SXmWFut9S3JQlZzm X-Received: by 2002:a62:4a51:: with SMTP id x78-v6mr6411673pfa.45.1530114746853; Wed, 27 Jun 2018 08:52:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530114746; cv=none; d=google.com; s=arc-20160816; b=vlLEUZBUQjd5TeDpbTmf5gVJdLRLQV2l0OAUzEGKPDe6ZlDVYFlB0NRwLlLoT1L8HA pvBhCI/zQHhZUczj6KcoC5ob4oRDkgxE3xXaSCcP9nATH2wD2J254gw76zKZby/SP0m0 w43RvWvx8JCPOV6hjPdD8fXrNbae4Lsh7MZ7n1bxZ4oj+BzFBPU6k0CaGkJSNUcZdgoc sNHdr+fr3Pa08cAcUKAsH1T1n0gHdKYj51SKvpqyt0JbGAYM/PiUkyyS1YIdo1nd+aOr wnfCzljtWcQPGfzGrm7co7f5bQezJCG2q321iDVXQen59b5F9q678l0ps1tlBLRtbGGo 9N4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=g1dE+fQyW8VJ6q38yfkGJFpUP+DhHwWMZeEEQVTfyY4=; b=hFDt0Pa3/TS64Y5ejC6FJ2Rgb4XKuLpFls6ixdMC7QPiEpKGF5/15vto3InrN/SP9c ME/HeIdPDZdni4GdsM9TziUDBY84TXd/Bk8w5TeaZO3gHrtw7H60mk6aABfVNv5H8XCX Ele/xDfnr/GzF0FRWLLIRsLtFyNMpcaG6QfAMg+IbHeAsdqM25MDrj2fiArOcuxDyYwX SRbvWD2fEJaSl21enzrR/GEvUKEDH63dib3gGF4Oe2y/IiL05SNJvJsOPty/BYN5fkWG ZvRbZgKDMzF9lvDseLl66d+pj6h2rqA8i5Bnpx5Z21cma8RNeTvO1AgmXEUIWXbW/ZzH 3VoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t186-v6si3899491pgd.3.2018.06.27.08.52.12; Wed, 27 Jun 2018 08:52:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754899AbeF0Pv1 (ORCPT + 99 others); Wed, 27 Jun 2018 11:51:27 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:54638 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbeF0PvZ (ORCPT ); Wed, 27 Jun 2018 11:51:25 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 219D1200A7; Wed, 27 Jun 2018 17:51:24 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QtuP4LJxn-Tb; Wed, 27 Jun 2018 17:51:23 +0200 (CEST) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 353172018E; Wed, 27 Jun 2018 17:51:23 +0200 (CEST) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.399.0; Wed, 27 Jun 2018 17:51:22 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id BC0023182281; Wed, 27 Jun 2018 17:51:22 +0200 (CEST) Date: Wed, 27 Jun 2018 17:51:22 +0200 From: Steffen Klassert To: Zhen Lei CC: Herbert Xu , "David S. Miller" , Alexey Kuznetsov , "Hideaki YOSHIFUJI" , netdev , linux-kernel , Hanjun Guo , Libin , YueHaibing Subject: Re: [PATCH 1/1] esp6: fix memleak on error path in esp6_input Message-ID: <20180627155122.i6lbultmbqpq5nte@gauss3.secunet.de> References: <1530071368-15156-1-git-send-email-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1530071368-15156-1-git-send-email-thunder.leizhen@huawei.com> User-Agent: NeoMutt/20170609 (1.8.3) X-G-Data-MailSecurity-for-Exchange-State: 0 X-G-Data-MailSecurity-for-Exchange-Error: 0 X-G-Data-MailSecurity-for-Exchange-Sender: 23 X-G-Data-MailSecurity-for-Exchange-Server: d65e63f7-5c15-413f-8f63-c0d707471c93 X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 X-G-Data-MailSecurity-for-Exchange-Guid: 7AC44A6E-4FD9-4D72-A430-BFC6E279EBD3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2018 at 11:49:28AM +0800, Zhen Lei wrote: > This ought to be an omission in e6194923237 ("esp: Fix memleaks on error > paths."). The memleak on error path in esp6_input is similar to esp_input > of esp4. > > Fixes: e6194923237 ("esp: Fix memleaks on error paths.") > Fixes: 3f29770723f ("ipsec: check return value of skb_to_sgvec always") > > Signed-off-by: Zhen Lei Applied, thanks a lot for the fix!