Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1530123448.7898.233.camel@surriel.com>
Subject: Re: [PATCH 3/6] x86,tlb: make lazy TLB mode lazier
From:   Rik van Riel <riel@surriel.com>
To:     Andy Lutomirski <luto@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        kernel-team <kernel-team@fb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mike Galbraith <efault@gmx.de>, songliubraving@fb.com
Date:   Wed, 27 Jun 2018 14:17:28 -0400
In-Reply-To: <CALCETrVgDXe6NFCmxhyiwMEQmQqyidAh+wQBWeaCKg+z6jQOPw@mail.gmail.com>
References: <20180626173126.12296-1-riel@surriel.com>
         <20180626173126.12296-4-riel@surriel.com>
         <CALCETrVgDXe6NFCmxhyiwMEQmQqyidAh+wQBWeaCKg+z6jQOPw@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-hBhus1lTWfAfBvnX7Yzb"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-hBhus1lTWfAfBvnX7Yzb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2018-06-27 at 11:10 -0700, Andy Lutomirski wrote:
> On Tue, Jun 26, 2018 at 10:31 AM Rik van Riel <riel@surriel.com>
> wrote:

> In general, the changes to this function are very hard to review
> because you're mixing semantic changes and restructuring the
> function.
> Is there any way you could avoid that?  Or maybe just open-code a
> tlb_gen check in the unlazying path?

Let me re-do v2 of the patch series in a way that
splits out the restructuring from the semantic
changes.

I already have code here that open-codes the tlb_gen
check in the unlazying path (not in v2 yet).

--=20
All Rights Reversed.
--=-hBhus1lTWfAfBvnX7Yzb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAlsz1LgACgkQznnekoTE
3oMc1wf/Vk8GEHNYU13d10NuuHt03KKmn7PiSHuvlQkKua0xYHq21J0DY+LfvM7Z
hv3QyTxOAcJAYRqs6a+i17YzJBKbPqNhh4VUjZJr0l3k+BAV8MzZ7gVzAoustqmb
iXdzWQu+/9Ads/uLlq9P8Ir+s+BzdOLfyaMfbB++f9OayPeWofaUx4H2vpjsY4SS
ku4UzG3OOAnWn/9YUQznS8PthmGb4VaJUVvfiFF9YE0Y6utGzxlO8RsCChyob0yK
6na8RAyQiPsRPTnSsvq1CqC4+vOFMhnX2Ky521NEDaNgNvOuAbnOaYJ3XOK8FXLm
MVsR4gjzNUkjX5kHgQm7RificqedYw==
=9Mqq
-----END PGP SIGNATURE-----

--=-hBhus1lTWfAfBvnX7Yzb--