Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6799822imm; Wed, 27 Jun 2018 13:40:52 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfxPIurYVkcgEh9fuGe0vcFPBSfaOOCUiDxnYPMGQJpN8WUugOxFwrmY07f9izqBnltms9s X-Received: by 2002:a62:4ed4:: with SMTP id c203-v6mr7372945pfb.213.1530132052067; Wed, 27 Jun 2018 13:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530132052; cv=none; d=google.com; s=arc-20160816; b=BqQV36WrFB4pdVDRaBINW/hu4fFJW2euenqb+DtN0GF2TVenkentKsUo0N9o5A2Ora mITW02YJRoYO37uArfSsbHGiA7Oy0nFRfzQ33wOHw3WvVACz5vuyASa1MAHqHX0cy330 dj6otAVTIZa2EFQiNSMqYvdrPQxW3GPuvYsFYxL8zwK3rqZiJ1eMlqPF8OEDgkDLzA0/ u44iewQxTENyeRT8CIprfQL+Ex0XLe/6foE+zh65fkGolOyC7lVkit81fcYihxxtfDIL I3RMdlZDfyKDuL0QmoIdlJEBZYAb0s4yeL2StFfyLFEIubl4FI8hL8YMSazPfU8Dj3Qg vKHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=mXG1rN3/+coQUtC6s8bfmPmB6yWi8gjdU+ivgQx4zVU=; b=ozn40JEhEU9HRMx3jRTWYmRddoulXBZr5vTC3EoeVtnD8HSL9F6LEkeGjDPpnp/5PB kl7h12FClwkJwY0vO9X6jI9OmjaS2kQDHo5/7S0MoG3pyV6VcuT1A0oBHROCBY9VR2Hx +1m8zqhGAIdqC5+KavNqOiXmJ9CI/V3hjCFp+D2yOS5GvyM4f9L+J8lIUyWAihHi0ZbK ifEvOH7SmLggIWHuWpvQElrQ2H13zOvK7Xj35oKhX/DIrEEEPeMLpKR4XAaHAN8XX0tw RUaCsXcwA8BnxiTvR8eEnvJ7R3YFM5+MNpE9nI99nVEXgZ0EiWbDWiVUnzkrg+I+nPR5 j24w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n29-v6si4573407pfg.227.2018.06.27.13.40.37; Wed, 27 Jun 2018 13:40:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935149AbeF0Tol (ORCPT + 99 others); Wed, 27 Jun 2018 15:44:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:29762 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933703AbeF0Toj (ORCPT ); Wed, 27 Jun 2018 15:44:39 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 12:44:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,280,1526367600"; d="scan'208";a="67832413" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by fmsmga001.fm.intel.com with ESMTP; 27 Jun 2018 12:44:38 -0700 Date: Wed, 27 Jun 2018 13:44:38 -0600 From: Ross Zwisler To: Matthew Wilcox Cc: Ross Zwisler , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v14 00/74] Convert page cache to XArray Message-ID: <20180627194438.GA20774@linux.intel.com> Mail-Followup-To: Ross Zwisler , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , Jeff Layton , Lukas Czerner , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net References: <20180617020052.4759-1-willy@infradead.org> <20180619031257.GA12527@linux.intel.com> <20180619092230.GA1438@bombadil.infradead.org> <20180619164037.GA6679@linux.intel.com> <20180619171638.GE1438@bombadil.infradead.org> <20180627110529.GA19606@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180627110529.GA19606@bombadil.infradead.org> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2018 at 04:05:29AM -0700, Matthew Wilcox wrote: > On Tue, Jun 19, 2018 at 10:16:38AM -0700, Matthew Wilcox wrote: > > I think I see a bug. No idea if it's the one you're hitting ;-) > > > > I had been intending to not use the 'entry' to decide whether we were > > waiting on a 2MB or 4kB page, but rather the xas. I shelved that idea, > > but not before dropping the DAX_PMD flag being passed from the PMD > > pagefault caller. So if I put that back ... > > Did you get a chance to test this? With this patch it doesn't deadlock, but the test dies with a SIGBUS and we hit a WARN_ON in the DAX code: WARNING: CPU: 5 PID: 1678 at fs/dax.c:226 get_unlocked_entry+0xf7/0x120 I don't have a lot of time this week to debug further. The quickest path to victory is probably for you to get this reproducing in your test setup. Does XFS + DAX + generic/340 pass for you?