Date: Thu, 11 Sep 2003 00:32:47 +0100
From: Russell King <rmk@arm.linux.org.uk>
To: Greg KH <greg@kroah.com>
Cc: rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [RFC] add kobject to struct module
Message-ID: <20030911003247.V30046@flint.arm.linux.org.uk>
Mail-Followup-To: Greg KH <greg@kroah.com>, rusty@rustcorp.com.au,
	linux-kernel@vger.kernel.org
References: <20030909222421.GA7703@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030909222421.GA7703@kroah.com>; from greg@kroah.com on Tue, Sep 09, 2003 at 03:24:21PM -0700
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1224
Lines: 29

On Tue, Sep 09, 2003 at 03:24:21PM -0700, Greg KH wrote:
> A while ago we had talked about adding a kobject to struct module.  By
> doing this we add support for module paramaters and other module info to
> be exported in sysfs.  So here's a patch that does this that is against
> 2.6.0-test4 (it applies with some fuzz, sorry.)

Please excuse my short-sightedness, but I think the following points
haven't been thought deeply enough:

- modules which use their parameters on initialisation only once.
  (eg, 3c59x "full_duplex" parameter)

- Also, what about module parameters which modules aren't expecting to
  change beneath themselves? (eg, all the watchdog modules)

- Are we opening the floodgates for another round of races and driver
  updates?

-- 
Russell King (rmk@arm.linux.org.uk)	http://www.arm.linux.org.uk/personal/
Linux kernel maintainer of:
  2.6 ARM Linux   - http://www.arm.linux.org.uk/
  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/