Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp6944447imm; Wed, 27 Jun 2018 16:41:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLCTKbSWwC8TE6+eVD0MbmIoU9vo8yUpDC54tFnc1E6uShqxbT9uATNZ6p/Z87b7ZPWoJtz X-Received: by 2002:a17:902:2c83:: with SMTP id n3-v6mr7925502plb.211.1530142864156; Wed, 27 Jun 2018 16:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530142864; cv=none; d=google.com; s=arc-20160816; b=N6fsPP37RVgqp9vQITjo51yjoUt3/tMyDKxdVVdZcwfpCiUqr1VVn5uGyKjDJjPBzT 4YHSSQPtvQjdx3QjYruTCy2I+xeISc1wU87dz43VMTbGlkgsLJ60wCB8vEfRkkhE1uFU 7+osptj80UxAZbZ694/ImROf9o4A1tIUsvDlWxSvFv1Pdvmq7RCvboQFIgR6mNNB41LY 4kxDlC770u+33CvBmFzAPpwls5D/KS8xdUaEVUuGD18pFShnn/654Q/zqHARP56bOjDa Daz16jjiCjw+tL/8YHgXG5RZtFYWTArOKbMOKgdS8HI3IPrMK3+5wBxFr4jA5tOXp1Rg YFfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=pHfoWW1r1zP1mhg18OeGm0K7Ho4rcvqHLsuFybGOhho=; b=OcUeIKNf3gxVPD+W6JCVrP9iGPwnKE3nnsNe2ku7i0O4uqYmQVh59YmsY4eiNDEYbs GC1PvyCPWHqRZFGgiBnDtvaB9u+Ok+ldwwKynJWkLdvQmuoNj/Q/ZMFwFCiEf5+K3R+Z Rp/9dCIUq0KHyBFGfxwdN1u4PG7ubJXWXm2E6j3R+tboy1erm+zTkIvlcPta9PRufHeW jRr9XKH2NO+4YYs0CMDZDlZURgIUM4ZsjiYzwgFyHySDv7DuLsftgHYxUVoQG5g8BAHo 1N9XB/Wa4ilZO5vFpzYkvOIm4Fg8NdK91iA7gJzL0m3otu8POm1D3LrSu3LTiUGGwPNz b9vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o3-v6si5272710pfa.15.2018.06.27.16.40.49; Wed, 27 Jun 2018 16:41:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965721AbeF0Vwi (ORCPT + 99 others); Wed, 27 Jun 2018 17:52:38 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46182 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751986AbeF0Vwh (ORCPT ); Wed, 27 Jun 2018 17:52:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4F137401DEC0; Wed, 27 Jun 2018 21:52:32 +0000 (UTC) Received: from localhost (unknown [10.18.25.149]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FBF11C70A; Wed, 27 Jun 2018 21:52:27 +0000 (UTC) Date: Wed, 27 Jun 2018 17:52:27 -0400 From: Mike Snitzer To: Kees Cook Cc: Mikulas Patocka , LKML , dm-devel@redhat.com, Dan Williams , Alasdair Kergon Subject: Re: dm: writecache: Use 2-factor allocator arguments Message-ID: <20180627215227.GA13549@redhat.com> References: <20180618175033.GA2627@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 27 Jun 2018 21:52:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 27 Jun 2018 21:52:37 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'msnitzer@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27 2018 at 5:48pm -0400, Kees Cook wrote: > On Mon, Jun 18, 2018 at 10:50 AM, Kees Cook wrote: > > This adjusts the allocator calls to use the 2-factor argument style, as > > already done treewide for better defense against allocator overflows. > > Additionally adjusts style nit to avoid assignments in test expressions. > > > > Signed-off-by: Kees Cook > > Friendly ping -- I'd like to make sure this makes it into 4.18. All > other 2-factor allocations have been fixed in the kernel. Yeap, I'll be sending it to Linus this week. Already staged and ready to go, please see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.18&id=50a7d3ba7c9ac5e0b7e03fc7f420180989361dbf Thanks, Mike