Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7050958imm; Wed, 27 Jun 2018 19:06:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpelbzthvd2cC29KWQxmsbayQRiwDEwmtkSsibXz7AoKDKTkh9UViFX8w4bmLA0HCoqbpiz5 X-Received: by 2002:a63:9a52:: with SMTP id e18-v6mr6266019pgo.188.1530151582505; Wed, 27 Jun 2018 19:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530151582; cv=none; d=google.com; s=arc-20160816; b=0wE+mqXKyTnhwxrjt83zxLTc3yj332dPjVQD4broOYAW0tazhmmRCxaAIgACD1AawX ZDTyskEDMeEXivUURKurmo6Uk0QP2igwkBgjEJH4A/X/GDcNW1pkTJvoScSQfLzfxBQ7 MHp/TEjkWMKfvDo9rsRLpq3q4XG1uwxIJsebSSSFK3VZWzPu7wa5ZuVombWM9VuJd7l2 ZM8NHrLFoggMyee2pWgEW5UCjKYStEJDBmdRaNGPvQ/I4E5hML6M8vPXt15GotfiuuWu jC6yZvabK/JTwK9gVIlKy31rdywcUAoePx4xsXv1HPSjfWbsCIG05pxK0O5wwj08n1e7 xePg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=KY4fKmKbMml2ykIN6H+ZZu9s3xL/zIb+xn0usWTnCp0=; b=o0fyDja8nH8F/7eDEoZsJ4SzdtuXdQv5Tw8hzRW9CHraN30ksyqrFP3AiwE8GwS1Ty L52WQouVdjZdTY2JwY17oYuTeLuSKmasGunWBwy+2MXU7HB14xAJsJpH32PqvNquc7ON 1qBjXo3hCTc9iR1HPPGGOY2aibKVfsQzIVMqVNKDSxmZ5fTQEDlTQLDjWFlgH+0dQDts NnPG1eBjxtqlcp8pYCtqbDxbsIsihaG1pwUp9WDM2JMzv5Tp2xIPIr5rjyoXkZqiJ92I pHrfeCz/GG3Y1SyvfXG2J2EADhzfGs7sywQstTcH+sjAeWMMBjTfl6iJ+3eHh1u2CBa2 Ng2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q5HkMCn5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 73-v6si4776031pga.99.2018.06.27.19.06.07; Wed, 27 Jun 2018 19:06:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q5HkMCn5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbeF1CF0 (ORCPT + 99 others); Wed, 27 Jun 2018 22:05:26 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:44964 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752257AbeF1CFY (ORCPT ); Wed, 27 Jun 2018 22:05:24 -0400 Received: by mail-pf0-f195.google.com with SMTP id j3-v6so1823730pfh.11; Wed, 27 Jun 2018 19:05:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KY4fKmKbMml2ykIN6H+ZZu9s3xL/zIb+xn0usWTnCp0=; b=Q5HkMCn5L51X18IMAqlCNc7ri87k0EYhKOHZRuZiiVg5Bs/Jsst55ZsxZT9OBd9pJE 8a8llvSc1VYmjfGlnOavC2JvgCQLiHmorwLyzy6WUxBmlJKfwXHEuO1Gj8jGXNjea57E Wgj/EIy+JsxpJwzAiyNAuFBBUKmNEeYQ/3O2rYsP9/yaUULt3grue5nh/l9CrhOsYL/j /fIg1vlqrmRGMv3Vvq4/d7GuDUBSzvR/3J8cs2DCc3I2NSJawmTd5Zbp9v/rWS+9X08y lLavglJSmpnf0gEzTDoJ0c3E95R9nhmMcOFJrFADVuW0NOepKwjrslgswBQwmDuSmHou Kb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KY4fKmKbMml2ykIN6H+ZZu9s3xL/zIb+xn0usWTnCp0=; b=ekP770QTVyShFNAR4rr9YWvmWPgVW6bKod1wUj5Phr8c0QfR49dETysO1mXLLT7IuM rzOMSnMN7Aoh6mS14EzbhQBPMB5ADledFqqoNW0uZpatFioLwHPGinAU6Pg1+CaWHvyB bQjwvMJ/RJWPwu/ZC42tK2SpWnZ0Yqld5ht1nGWtWcGIAgZRMI3gMif7k4PTb6p8TexN dUyNbqm8vZMKbd7Ov4sbuJR+V6W/MGvRqlAn8z42rjBSK92APk/MoE8YljAV28VDO1o0 9PdhOOfhnp1BpYa8dngG14Zcrs6gPkWdD4mc/OmHwWAPMxEwlRpbAaKHI/zTEzwm6dxL 98ag== X-Gm-Message-State: APt69E26rhv3ftabZYMn9U3LfcqxYBITWgq8C2ni3BhhDAgX+BJ0k1P2 be6ogB/2mxMYiHdjhbvsi7U= X-Received: by 2002:a62:e03:: with SMTP id w3-v6mr8195415pfi.173.1530151523696; Wed, 27 Jun 2018 19:05:23 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:180::1:d9d0]) by smtp.gmail.com with ESMTPSA id h12-v6sm7715227pfi.114.2018.06.27.19.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 19:05:22 -0700 (PDT) Date: Wed, 27 Jun 2018 19:05:21 -0700 From: Alexei Starovoitov To: Masahiro Yamada Cc: "David S . Miller" , netdev@vger.kernel.org, Matteo Croce , Arnd Bergmann , linux-kbuild@vger.kernel.org, Alexei Starovoitov , linux-kernel@vger.kernel.org, Michal Marek , Daniel Borkmann Subject: Re: [RESEND PATCH] bpfilter: check compiler capability in Kconfig Message-ID: <20180628020519.txhrgq627cnhqspe@ast-mbp.dhcp.thefacebook.com> References: <1529985336-27522-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529985336-27522-1-git-send-email-yamada.masahiro@socionext.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 26, 2018 at 12:55:35PM +0900, Masahiro Yamada wrote: > With the brand-new syntax extension of Kconfig, we can directly > check the compiler capability in the configuration phase. > > If the cc-can-link.sh fails, the BPFILTER_UMH is automatically > hidden by the dependency. > > I also deleted 'default n', which is no-op. > > Signed-off-by: Masahiro Yamada I haven't tested it yet, but looks good to me as well. Thank you for the follow up. Acked-by: Alexei Starovoitov