Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7110145imm; Wed, 27 Jun 2018 20:35:50 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfog7R7bxBqRTKpSVWHf50HTj21XNiFEAl5BcWJFejjzLamUrLS6ejgidom644DBc5IiBoW X-Received: by 2002:a62:40dc:: with SMTP id f89-v6mr8359462pfd.194.1530156950295; Wed, 27 Jun 2018 20:35:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530156950; cv=none; d=google.com; s=arc-20160816; b=cawb7NX8ZFcFdMnOO9B4QzdM4gBNHW8WQBTGxJvUOs1gEsZvLYBn2SLoFJoRZwJKVd TqA/1cTkqvmL7zIzAFNZIQG1NNe/QEgzj4Sjo3bO8v4wKzLYp1xoDkHyrdEY5gsB4LGP DwjbuGwLFcZZ5MmxYo8v5PggryHIQM7rojt6wQ89kNv3agYPiV2qdt2j9mugOpIcC5Qy y7p7kq//x4jzYKANyvXdvMpTW3iFSoWoii4JzdqMj6AikmtRo83LqHgyoSr9sa85pHle lHcSPcz81hY7j8qyZba6MCARZT1/yb137sCJzrU6yxAujCoIRnktTCA7tvJ1y2+g4IKR op7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=90CmZm36Pi4VWI7duTIG4R+1FJ2DdgHFg3dvS/8BaVU=; b=ISsDJw/3P/kk91L0X8bUcpckK5pkkY7MNn7YoiiEhnM8qvNU1lTbbj0cP/E//1SP74 HLWWgKnYZEGTE57nOwAnNV8hnMzXDV9EYnhw+r7cpycNrzSWwkHUcXfovtikBTkDxtT2 UTxsIzvJE7YPa5++h183JFtoxji0PJ6DOf+aKFGY9sIhcOGrYjb3g6OpLcmZUoXfR3lq SDzxXKEkyFOOcECBQPAAUfLG0L7AlOdO/F4S2ije8CCagSctbvRxeaQxLzY2UdjUWa1a mVng+v68k6X1Skdr/wbE/A/WUFkUnxdvqPDzkVHkR6yNKP2ptIvdnTZ2dOA+zJ4OCVuK kQvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=VKovN3jF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14-v6si3964490pgm.502.2018.06.27.20.35.36; Wed, 27 Jun 2018 20:35:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=VKovN3jF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933050AbeF1DUD (ORCPT + 99 others); Wed, 27 Jun 2018 23:20:03 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:57458 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932577AbeF1DUC (ORCPT ); Wed, 27 Jun 2018 23:20:02 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5S3J9RF122120 for ; Thu, 28 Jun 2018 03:20:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : references : in-reply-to : from : date : message-id : subject : to : cc : content-type; s=corp-2017-10-26; bh=90CmZm36Pi4VWI7duTIG4R+1FJ2DdgHFg3dvS/8BaVU=; b=VKovN3jFe2KLf6aoXW1h5zBUBIWZiRAsXjwI2WS7UjzZasrcGZcy43Br8pz0TmzUbM1b MToBtdtGSBysTLYA4HtG6u4L0pXUSatRA2ZMW2BltKd8zSZZ+owJnykxv7ZUXcaBseG6 gOkbGvaMVVaK8rIyenpWY08pA2v10ZbN7y+m48u7noyVNOgBI9tHfxRfjMWgLjNxMhVH kEUOszlwPtChR/kym7C5snz2KEar6RBmu5nTaTr+YZJcZyC32YWd1Js4vPibB3g06ash cvZNbVFU3f8IlCbWu3fd7/cad/C2KDftADOxveon8K2LJNQF5IX6wa6feYKF/xfCz6H6 Vw== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2jum58026f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 28 Jun 2018 03:20:01 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w5S3Jx8r013893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 28 Jun 2018 03:20:00 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w5S3Jxvx000780 for ; Thu, 28 Jun 2018 03:19:59 GMT Received: from mail-oi0-f53.google.com (/209.85.218.53) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Jun 2018 20:19:59 -0700 Received: by mail-oi0-f53.google.com with SMTP id n84-v6so3827789oib.9 for ; Wed, 27 Jun 2018 20:19:58 -0700 (PDT) X-Gm-Message-State: APt69E3wgDVhjEwLVErgYeoY4tw0wKsFNUkGNs5SRfmNnGtwfo2eeafx vUF+6VVQz5ABZgfuwhFKj9UCXQRjnlVnp8GfCQ8= X-Received: by 2002:aca:db0a:: with SMTP id s10-v6mr5053639oig.339.1530155998748; Wed, 27 Jun 2018 20:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20180627013116.12411-1-bhe@redhat.com> <20180627013116.12411-5-bhe@redhat.com> In-Reply-To: <20180627013116.12411-5-bhe@redhat.com> From: Pavel Tatashin Date: Wed, 27 Jun 2018 23:19:22 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init() To: bhe@redhat.com Cc: LKML , Andrew Morton , dave.hansen@intel.com, pagupta@redhat.com, Linux Memory Management List , kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="UTF-8" X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8937 signatures=668703 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=455 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1806280033 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Signed-off-by: Baoquan He > > Signed-off-by: Baoquan He Please remove duplicated signed-off > if (!usemap) { > ms->section_mem_map = 0; > + nr_consumed_maps++; Currently, we do not set ms->section_mem_map to 0 when fail to allocate usemap, only when fail to allocate mmap we set section_mem_map to 0. I think this is an existing bug. Reviewed-by: Pavel Tatashin