Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Jun 2018 07:39:52 +0200
Message-ID: <s5hmuvf5v13.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Guy Chronister" <guylovesbritt@gmail.com>
Cc:     <guychronister@outlook.com>, <alsa-devel@alsa-project.org>,
        "Clemens Ladisch" <clemens@ladisch.de>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fixed typo on line 733.
In-Reply-To: <1530125674-11412-1-git-send-email-guylovesbritt@gmail.com>
References: <1530125674-11412-1-git-send-email-guylovesbritt@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 27 Jun 2018 20:54:34 +0200,
Guy Chronister wrote:
> 
> Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>

The code change itself is good, but the subject is wrong, and there is
no changelog texts.  Please describe what it really fixes.  It's not
about typo fix, but it fixes a real bug, and this has to be written in
the subject and explained in more details in the changelog.


thanks,

Takashi

> ---
>  sound/pci/oxygen/oxygen_mixer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
> index 81af21a..ba87213 100644
> --- a/sound/pci/oxygen/oxygen_mixer.c
> +++ b/sound/pci/oxygen/oxygen_mixer.c
> @@ -730,7 +730,7 @@ static int ac97_fp_rec_volume_put(struct snd_kcontrol *ctl,
>  	oldreg = oxygen_read_ac97(chip, 1, AC97_REC_GAIN);
>  	newreg = oldreg & ~0x0707;
>  	newreg = newreg | (value->value.integer.value[0] & 7);
> -	newreg = newreg | ((value->value.integer.value[0] & 7) << 8);
> +	newreg = newreg | ((value->value.integer.value[1] & 7) << 8);
>  	change = newreg != oldreg;
>  	if (change)
>  		oxygen_write_ac97(chip, 1, AC97_REC_GAIN, newreg);
> -- 
> 2.7.4
> 
>