Received: by 2002:ac0:a581:0:0:0:0:0 with SMTP id m1-v6csp7264012imm; Thu, 28 Jun 2018 00:19:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcJpd7i77QiS14SU8jyu0iEXr+KSXuhqXovjjyvcHn39tEqTaHaso6jwlBX+9tS3s7CjEKH X-Received: by 2002:aa7:810c:: with SMTP id b12-v6mr8903176pfi.79.1530170360667; Thu, 28 Jun 2018 00:19:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530170360; cv=none; d=google.com; s=arc-20160816; b=1JVX9Hryfjn6s1/1fwnUbRCDSTcnluwF+gnJnA+Ba+5ZpWYBHiEQLSunSy0Wiy1IuH kMtItoSSs+sHTMeDd76+t/7n3IXZwDaUWiwR4SPMsGtv5XzaQGjzkUFfT0guACEjOq87 JnRGsZcZ1T7Of7/hIWV2kBSb4tvsxOim+EZcfyPdYNgG8zoOxZWwj7lNura2Wgxaw5jh 7eCYy+J2PqqwFx1kPRdkp9VNLs6fAl1PAb/J9kw5izgkT5DzhP/9ddThPigHiL6Mv7Q3 HKfaDo4/LM3t9tcP01tvjId3547mJo3HozclJNKi7vtF1sALgZIVusqRARgfMSS4h66I KJnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=apSRmUzqNo0d9PsT8C2RCctfIXk+zemhFGLB5RG5mHs=; b=S3F7edVztCUYBcYvi4XWU4JK8QyRwl8Ph1arCxbvgBeqLMjriX1C+7jClpMwjxB2RW SgBdxQAj3rxUUBCqG0Ngdz85R/nG79BHc2DMcgjYRP5YSukx6zYC0oDZU1DcIvSEyBGK yVwh5NIbghmLNzUBS9FrPRg5WSyVbBXPqgsnAn4uBBfJ7wlvvtRS01OrO1eLsnljyXUJ 5Jya5e+2MJAidlznKCDwvD8wA0jb5sqHatnGIRQ5uYbkbY5HoASzJ3J3CD1qgLvRZNsH L/HNtI/MwscDdl1T/kM3FMtZJW7X3TC6AXXm3qONTgCBxQavBRfzd0x/8MKAFoLg13aQ 2IJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3-v6si5967543pfj.231.2018.06.28.00.19.06; Thu, 28 Jun 2018 00:19:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933944AbeF1HNC (ORCPT + 99 others); Thu, 28 Jun 2018 03:13:02 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46928 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932131AbeF1HM7 (ORCPT ); Thu, 28 Jun 2018 03:12:59 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E0BCA10177610; Thu, 28 Jun 2018 00:12:54 -0700 (PDT) Date: Thu, 28 Jun 2018 16:12:52 +0900 (KST) Message-Id: <20180628.161252.209496989512611440.davem@davemloft.net> To: brandon.maier@rockwellcollins.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com, kristopher.cory@rockwellcollins.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 3/3] net: phy: xgmiitorgmii: Check read_status results From: David Miller In-Reply-To: <20180626175050.71165-3-brandon.maier@rockwellcollins.com> References: <20180626175050.71165-1-brandon.maier@rockwellcollins.com> <20180626175050.71165-3-brandon.maier@rockwellcollins.com> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Jun 2018 00:12:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Brandon Maier Date: Tue, 26 Jun 2018 12:50:50 -0500 > We're ignoring the result of the attached phy device's read_status(). > Return it so we can detect errors. > > Signed-off-by: Brandon Maier Applied.